Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2240. Re-write waitlist functionality #2384

Closed
wants to merge 54 commits into from

Conversation

krishnasaurabh
Copy link
Contributor

Changes in this pull request:

  • Added new table waitlist_teams
  • Segregated functionality of waitlisting of teams from signed_up_teams table to waitlist_teams
  • Better control of waitlist and cleaner and maintainable code.
  • Fixes multiple bugs during waitlists, by using reliable atomic changes with transactions, and proper error handling.
  • Added test cases to cover all scenarios and edge cases.

Akhil Kumar Mengani and others added 30 commits April 19, 2022 22:41
Added waitlist_teams table and model file
…ist_methods

changed schema, and added create/delete waitlist
…ist_methods

added more methods and fixed num on waitlist colum
…list_methods

migrate waitlists from signed_up_teams to waitlist_teams
Added methods to handle deletion cases
Check if team is waitlisted for other topic before signup
Release signup and waitlist Functionality , WaitlistTeam RSpec
…ggestion_controller.rb

Changes for synchronizing waitlist features with invitation.rb and suggestion_controller.rb
@coveralls
Copy link

Coverage Status

Coverage decreased (-34.0%) to 17.193% when pulling d8cf3bd on akhilkumarmengani:beta into 4c3174c on expertiza:beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-34.0%) to 17.193% when pulling d8cf3bd on akhilkumarmengani:beta into 4c3174c on expertiza:beta.

@coveralls
Copy link

coveralls commented May 1, 2022

Coverage Status

Coverage decreased (-0.2%) to 51.001% when pulling 511209d on akhilkumarmengani:beta into 4c3174c on expertiza:beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants