changed schema, and added create/delete waitlist #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnasaurabh
pushed a commit
that referenced
this pull request
May 1, 2022
* Simplified 'If' statement on line 58 * Removed Unnecesary Instance Variables in Update * Instance variable correction * Simplified elseif conditions in update * Refactor edit new form (#1) * Removed somwhat duplicated code from the view, WIP: fixing the controller code to retrieve form data sent by the browser in create action * consolidated input validation for create and update methods into a single function. Fixed a small syntax error * fixed common mistakes: 1. changed variable name to conform snake_case from camelCase 2. removed redundant comments * Fixed a bug: the consolidated input validation code was checking for duplicate name when the name was not changed during edit * WIP: changed late_policy_controller test to give more specific error message when penalty per unit is less than zero * Fixed a number of failing tests in late_policies_controller due to mismatch in error message string * Fixed a typo Co-authored-by: Shawn Salekin <ssaleki@vclv98-113.hpc.ncsu.edu> * Refactor edit new form (#2) * Removed somwhat duplicated code from the view, WIP: fixing the controller code to retrieve form data sent by the browser in create action * consolidated input validation for create and update methods into a single function. Fixed a small syntax error * fixed common mistakes: 1. changed variable name to conform snake_case from camelCase 2. removed redundant comments * Fixed a bug: the consolidated input validation code was checking for duplicate name when the name was not changed during edit * WIP: changed late_policy_controller test to give more specific error message when penalty per unit is less than zero * Fixed a number of failing tests in late_policies_controller due to mismatch in error message string * Fixed a typo * Fixed failing test Co-authored-by: Shawn Salekin <ssaleki@vclv98-113.hpc.ncsu.edu> * Added Method Comments for late_policies.rb Added Methods for all the methods in late_policies.rb * Private public late policy (#3) * Added a dropdown for selecting late policy visibility. Removed commented out code * removed comments for concerns that were resolved * Changed form select values from 0/1 to false/true for private late policy * Migration for adding private column to the late_policies table * updated schema to reflect changes due to adding a new column in late_policies * More changes to the schema * Changed the query to return late policies that are created by this instructor or private ones * Private public late policy (#4) * Added a dropdown for selecting late policy visibility. Removed commented out code * removed comments for concerns that were resolved * Changed form select values from 0/1 to false/true for private late policy * Migration for adding private column to the late_policies table * updated schema to reflect changes due to adding a new column in late_policies * More changes to the schema * Changed the query to return late policies that are created by this instructor or private ones * Revert "updated schema to reflect changes due to adding a new column in late_policies" This reverts commit a31f2fd. * Revert "More changes to the schema" This reverts commit 0ba1038. * Revert "More changes to the schema" This reverts commit 0ba1038. * Revert "updated schema to reflect changes due to adding a new column in late_policies" This reverts commit a31f2fd. * removed extraneous comments from methods in late_policies_controller (#5) * Made formatting fixes based off rubocop feedback (#6) * Fixed a number of linting errors * Fixed a number of linting errors * Validate Input Test 1 * test 1 bug fix * Testing fixes * update migration * fix schema * use charset * fix typos * run migrations * fix collation * fix test * fix * fix test * try to fix some rubocop stuff * refactor code for rubocop Co-authored-by: wgplaga <143Kristie!!143> Co-authored-by: Sirajus Salekin <ssalek14@earlham.edu> Co-authored-by: Shawn Salekin <ssaleki@vclv98-113.hpc.ncsu.edu> Co-authored-by: stumma2 <94282212+sujith3179@users.noreply.github.com> Co-authored-by: John Bumgardner <38589044+johnbumgardner@users.noreply.github.com> Co-authored-by: John Bumgardner <john.bumgardner@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed schema, and added create/delete waitlist