E2252. Refactor auth_controller.rb & password_retrieval_controller.rb #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @greyfiles, |
…troller E2552. Refactor password retrieval controller
E2252. Refactor auth_controller.rb
…mments E2252. Rewrite error msgs and comments
…troller E2552. Refactor password retrieval controller
…taken that there was repeated code at all
Reverse change to add login_failed helper method
…troller Adding Rspec tests for update_password
E2252. Added additional tests for password_retrieval_controller.rb
Improved unit tests for auth_controller
…troller E2252. Added factories to password_retrieval spec test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.