Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2263 Refactor student_teams functionality #2467

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

SahithiAmmana
Copy link

@SahithiAmmana SahithiAmmana commented Oct 25, 2022

We have performed the following refactoring tasks specified for this refactoring project:

Changing the schema

  1. We renamed the table table teams_users to teams_participants

  2. Created a column that would be called “participant_id”, which will be a foreign key that references participants table.

  3. Created a migration that fetches the assignment_id for each tuple from the teams table. We would find the participant with the help of the assignment_id we just got from the teams table and the user_id that is already present in the current table, and store its “id” in the participant_id column we created in the last step. You have to come with optimal migration strategy that reliably calculates the participant_id

  4. Found out all the places where user_id is being used, refactored those so that participant id is used.

  5. Got rid of the user_id column.

Refactoring the teams rendering

  1. The logic in the team's view (where participants can see their team members) that iterates and fetches information of all the team members and displays them would be refactored so that it matches our new design.

  2. Migration is executed.

  3. Made partials and placing bloated functionality in their specific partials.

  4. The new changes do not break the view that works for data where things are populated with user_id.

Updated logic for all the crud functionalities in teams_users controller (wherever applicable).

Renamed the teams_users_controller to teams_participants_controller (and all its references)

Collaborators
@SahithiAmmana
@nagarajumadamshetti
Tyler Craine

@SahithiAmmana SahithiAmmana changed the title Refactoring users table E2263 Refactor student_teams functionality Oct 25, 2022
@SahithiAmmana
Copy link
Author

/help

@expertiza-bot
Copy link
Contributor

Available commands:
- /rerun
- /dispute [UUID]

@SahithiAmmana
Copy link
Author

/rerun

@expertiza-bot
Copy link
Contributor

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.

@nagarajumadamshetti
Copy link

/rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants