New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2263 Refactor student_teams functionality #2467
Open
SahithiAmmana
wants to merge
17
commits into
expertiza:main
Choose a base branch
from
SahithiAmmana:Refactoring_users_table
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
E2263 Refactor student_teams functionality #2467
SahithiAmmana
wants to merge
17
commits into
expertiza:main
from
SahithiAmmana:Refactoring_users_table
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SahithiAmmana
changed the title
Refactoring users table
E2263 Refactor student_teams functionality
Oct 25, 2022
/help |
Available commands: |
/rerun |
Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request. |
/rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have performed the following refactoring tasks specified for this refactoring project:
Changing the schema
We renamed the table table teams_users to teams_participants
Created a column that would be called “participant_id”, which will be a foreign key that references participants table.
Created a migration that fetches the assignment_id for each tuple from the teams table. We would find the participant with the help of the assignment_id we just got from the teams table and the user_id that is already present in the current table, and store its “id” in the participant_id column we created in the last step. You have to come with optimal migration strategy that reliably calculates the participant_id
Found out all the places where user_id is being used, refactored those so that participant id is used.
Got rid of the user_id column.
Refactoring the teams rendering
The logic in the team's view (where participants can see their team members) that iterates and fetches information of all the team members and displays them would be refactored so that it matches our new design.
Migration is executed.
Made partials and placing bloated functionality in their specific partials.
The new changes do not break the view that works for data where things are populated with user_id.
Updated logic for all the crud functionalities in teams_users controller (wherever applicable).
Renamed the teams_users_controller to teams_participants_controller (and all its references)
Collaborators
@SahithiAmmana
@nagarajumadamshetti
Tyler Craine