E2257.Further Refactoring questionnaires controller.rb #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailash1998s
commented
Dec 5, 2022
kailash1998s
commented
- changes from the previous E2257
- changes based on feedback from previous MR
- factory methods for both questionnaire and question (moved to their corresponding helper classes)
- remove around 3 methods in questionnaires_controller.rb that were not used
- Bugfix for updating questionnaire functionality
- removed unwanted constants in question.rb model
- bugFix for updating seq number for questions that are being added to the questionnaire
Feature kailash
…nctions, updates tests
Feature kailash
Made required changes based on the feedback of previous PR
Moved factory methods to helper classes
Changed access
removed debug code. and updated comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.