E2300. Refactor E1858. Github metrics integration #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating project
migration errors
Instead of controller: 'assignments', we can use the list_submissions_assignment_path helper method to generate the correct path for redirect_to. The unless statement in require_instructor_privileges can be simplified to a one-liner. I removed the only: [:action_allowed?] from require_instructor_privileges, since there is no action_allowed? method defined in the controller. I removed the comments that were not providing any additional value. Extracted some code to private methods to improve readability and organization. Removed unnecessary instance variables and local variables. Simplified the retrieve_github_data and create_github_metrics methods. Removed unnecessary @total_* instance variables. Removed the @check_statuses instance variable, which isn't used in this method. The retrieve_github_data method has been refactored to use partition instead of select, simplifying the code. In query_all_pull_requests, we've combined two lines of code to simplify the creation of the head_refs hash. We've also passed hyperlink_data to parse_pull_request_data instead of github_data to match the method's expected argument. Finally, we've refactored extract_hyperlink_data to use slice and zip to create the hash, which is shorter and easier to read. In pull_request_data, I replaced the while loop with a loop do construct and used break to exit the loop instead of modifying a flag variable. I also used the safe navigation operator (&.) to avoid NoMethodError exceptions when accessing nested hashes that may be nil. In parse_pull_request_data, I used the safe navigation operator to avoid NoMethodError exceptions when accessing nested hashes that may be nil. I also added some nil checks to skip over commits or commit data that is missing or invalid. Finally, I simplified the date slicing logic by chaining the to_s and slice methods. retrieve_repository_data now calls parse_hyperlink to extract the owner and repository names from the GitHub repository URL. It also uses a loop instead of a while to simplify the code and avoid unnecessary variables. query_and_parse_repository_data now returns the page info hash instead of modifying it in place, to make it clearer and less error-prone. parse_repository_data now uses dig to access nested hashes safely, avoiding errors if any of the expected keys are missing. It also simplifies the date string extraction by using a slice instead of a regex. Used the dig method to access nested keys in the hash, which returns nil if any intermediate key is nil instead of raising an exception. Removed unnecessary comments and made the existing ones more concise. Used ternary operator to simplify the if statement. Used dig instead of nested hash indexing with square brackets. This makes the code more concise and avoids NoMethodError exceptions when a hash key is missing. Used return to exit early from count_github_authors_and_dates if the author is a collaborator. This avoids unnecessary code execution and improves performance. Used Hash.new(0) to initialize the hash for each author's commits. This simplifies the code and avoids the need for if...else logic. Used default to set the default value for each author's commits to 0. This avoids the need for if...else logic when incrementing the commit count. Used to_h to convert the sorted array of commits back to a hash. This is more concise than building a new hash with Hash[]. Used dig to access nested hash keys in team_statistics. This avoids NoMethodError exceptions and makes the code more concise. Used ternary operator to simplify Used the find_by method instead of where and first for simplicity. Used the safe navigation operator (&.) to avoid errors when trying to call a method on a nil object. Used present? instead of nil? to check if a record exists. Used update instead of assigning values and calling save separately for readability. Used string interpolation to concatenate the @ncsu.edu suffix to the email prefix. Removed unnecessary comments and code.
E2300. Refactor E1858. Github metrics integration
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| unless Rails.env.development? | ||
| match '*path' => 'content_pages#view', :via => %i[get post] | ||
| end | ||
| get ':controller(/:action(/:id))(.:format)' |
Check failure
Code scanning / Brakeman
All public methods in controllers are available as actions in routes.rb. Error
| <% p team.submitted_files %> | ||
| <% if participant and !team.submitted_files.empty? %> | ||
| <% files = team.submitted_files %> | ||
| <%= display_directory_tree(participant, files, true).html_safe if files and files.length > 0 %> |
Check notice
Code scanning / Brakeman
Unescaped model attribute. Note
| <% participant = participants.compact.first %> | ||
| <% if participant and !team.hyperlinks.empty? %> | ||
| <% team.hyperlinks.each do |link| %> | ||
| <a href="<%= link %>" target="_blank">- <%= link %></a><br/> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do: Add wiki link