E2360. View for results of bidding #2659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Enable bidding" checkbox.
Shreshth-Malik
changed the title
…to main Conflicts: spec/controllers/lottery_controller_spec.rb
efg
reviewed
Nov 9, 2023
| redirect_to controller: 'tree_display', action: 'list' | ||
| end | ||
|
|
||
| def bidding_details |
There was a problem hiding this comment.
This name needs to be changed. It gives no hint of what the method does.
| <%= label_tag('assignment_form[assignment][is_intelligent]', 'Enable bidding for topics?') %> | ||
| <img src="/assets/info.png" title="This feature allow students to "bid" for topics. | ||
| Instructor must specify when topics are assigned, by going to the Due Dates tab and | ||
| entering a due date for "signup"."/> | ||
| <br> | ||
| <%= button_to 'View Bidding Details', {:controller => 'lottery', :action => 'bidding_details', :id => @assignment_form.assignment.id}, |
There was a problem hiding this comment.
Again, "details" is not specific enough to give an idea of what will be shown. Would "Show bids by priority" be better? Also, please capitalize only the first word on the button, not all words ... less "shouting", and notice that's how Github does it.
| @@ -0,0 +1,59 @@ | |||
| <h3>Bidding Details for <%= @assignment.name %></h3> | |||
| <thead> | ||
| <tr> | ||
| <th>Topic Name</th> | ||
| <th>Bidding Teams</th> |
| @@ -107,7 +107,7 @@ en_US: | |||
| mico_task: "Micro Task Assignment?" | |||
| review_reviewers: "Reviews visible to all other reviewers?" | |||
| calibrate_training: "Calibration for training?" | |||
| reputation_algorithm: "Reputation Alogorithm?" | |||
| reputation_algorithm: "Reputation Algorithm?" | |||
There was a problem hiding this comment.
--> "Reputation algorithm". Notice that the other strings capitalize only the first word.
… } to make sure that the block will be associated with the satisfy method call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please set the title of your pull request in the following format:
[Project id/Independent study/Issue fix/...]. project name, eg.,E904. Integrating courses and assignments on Expertiza with MoodleWe suggest you including the below information in your pull request:
About the Expertiza Bot
/dispute [UUID1] [UUID2](example), then the professor and TAs will be notified.