E2414 - Grading audit trail #2774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up Grading history base implementation
Tsenck/UI refactor
Btsima/grading history refactor
Updated testing
efg
reviewed
Apr 3, 2024
| if record == nil | ||
| @receiver = "" | ||
| @assignment = "" | ||
| else |
There was a problem hiding this comment.
This line needs a comment saying what the else condition signifies.
app/models/grading_history.rb
Outdated
|
|
||
| # populate the assignment fields according to type | ||
| def self.assignment_for_history(type, graded_member_id, participant_id) | ||
| # for a submission, the receiver is an AssignmentTeam |
There was a problem hiding this comment.
It's a class method, so the receiver is the class, no?
app/models/review_grading_history.rb
Outdated
| class ReviewGradingHistory < GradingHistory | ||
| attr_protected | ||
| belongs_to :graded_member, class_name: 'Participant' | ||
| end |
There was a problem hiding this comment.
Please add newlines at the end of files to avoid these annoying markers.
Refactoring Program 3 Changes
Make grading history table smaller, add tests
Update failing controller specs
Add newlines at end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a feature to maintain a history of all changes made to grades for assignments and reviews. When an instructor enters a grade for an assignment or review, they have the option to view the grading history, which will display a listing of all of the grades and comments previously given.
This feature also implements logging for all grade changes using the ELK logging system (ElasticSearch Logstash Kibana). Log messages are created after a grade is given to any submission or review
This implementation is based on on work from E2383, adding several UI formatting changes, refactoring to improve coding style, and additional controller tests