E1677: Text Metrics Project #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of reviews containing offensive, suggestive and error terms
|
Below are some comments for grading purpose only.
|
yangsong8
reviewed
Dec 8, 2016
|
|
||
| #diff_word_count = response_level_comments[current_response_id].scan(/[\w']+/).uniq.count | ||
| if ReviewMetric.exists?(response_id: key) | ||
| obj = ReviewMetric.find_by(response_id: key) |
There was a problem hiding this comment.
So review metrics is only calculated when the instructor visit this information ,right?
|
Dear Song,
Yes, we followed a approach where the instructor has been kept in control
of the review metrics in this case. Students will be able to see it after
the instructor has viewed the report once.
Thanks and Regards,
Spondon
…On Dec 8, 2016 11:11 AM, "Yang Song" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/models/review_metric.rb
<#892 (review)>
:
> + value.scan(/[\w']+/).each do |word|
+ word_counter = word_counter + 1
+ if offensive_words.include? word
+ is_offensive_term = true
+ end
+ if suggestive_words.include? word
+ is_suggestion = true
+ end
+ if problem_words.include? word
+ is_problem = true
+ end
+ end
+
+ #diff_word_count = response_level_comments[current_response_id].scan(/[\w']+/).uniq.count
+ if ReviewMetric.exists?(response_id: key)
+ obj = ReviewMetric.find_by(response_id: key)
So review metrics is only calculated when the instructor visit this
information ,right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#892 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUL0Aqv4yG1v4F6iNetR-rkgvwl6JWd7ks5rGCwigaJpZM4LHIcI>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of adding Text Metrics as a tool for the instructor and the student to check their reviews.