E2330. Reimplement Invitation Controller #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed test driven development to implement invitation model. Added FactoryBot to Gemfile.
rohitgeddam
changed the title
Added method signatures that will act as placeholders for further implementation.
implemented InvitationController#create update invitation.rb add validation to prevent duplicate invitation. add faker in Gemfile
Setup InvitationSentMailer for the purpose of sending invitations. Implemented invitation_factory to help with creation of a new invitation with the given parameters.
converted class methods to instance methods. renamed list_all_invitations_for_user_assignment to invitations_for_user_assignment.
update description in invitation_controller for swagger docs
added _ before parameters to signify unused paramater
updated test case descriptions in invitation_controller_spec.
Fix Rubocop issues
updated comments in invitation_controller.rb, invitation.rb for better understanding of the purpose of the unimplemented methods.
removed unused method remove_users_sent_invites_for_assignment
rohitgeddam
commented
May 2, 2023
rohitgeddam
commented
May 2, 2023
rohitgeddam
commented
May 2, 2023
mundra-ankur
requested changes
May 3, 2023
There was a problem hiding this comment.
Hey there!
I just reviewed your pull request and I must say, you did a great job with the implementation. However, I do have a few suggestions that I would like you to work on. Nothing major, just a couple of things that will make the code even better. Keep up the good work!
moved invitation model validations to invitation_validator. updated invitation spec files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Title: E2330. Reimplement Invitation Controller
Team: sgeddam2, ktelapr, dshah6
Mentor: Ankur Mundra