New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1-generate.md #110
Update 1-generate.md #110
Conversation
Describe how to run the same task multiple times.
Do you think that this is the best location to put this? |
hey @earcanal I just pushed some changes to your branch, I wanted to preview to see if the location was appropriate (I think it is) and also rephrase some of the sentences a bit (and add additional links). Take a look and let me know if my changes are good, and we can merge after! |
I think the location is OK, but you've twisted the use case a little. The way I originally framed it was that you want to run the same task (i.e. not two different versions of the ANT) multiple times, with a different task (that you hypothesise will have different effects on the ANT) in between. Your twist is an additional (very useful!) use case of running the same task multiple times with different variables to make it operate differently. I just wanted to capture the Dockerfile tweaking necessary to get the same task in multiple times. Maybe include a sentence after the simpler use case pointing this out, and referring to the **Participant Variables" section? |
I don't understand what you mean by the "same task" but "with a different task" - can you better explain? |
ohh you mean a third unrelated task? So the variable isn't ANT1 or ANT2, but some task in between? I still don't totally follow, lol. |
Both ANTs need to be run the same way so you can compare post treatment to baseline. |
Understood! Tho first and last lines come down to copying and renaming the folder / exp_id (what I thought this change to the docs was mentioning). You want to add the additional logic for the second line? How are you currently doing this? |
I guess we could, although it opens the can of worms of touching tasks so they understand
... and if we're explaining that, then we might as well go the whole way and recommend generating all the tokens require for your n in each group and configuring them in your variables file. Then use your preferred randomisation method to dish them out. |
I'm not sure what this PR intends to explain then. I changed the description to describe what expfactory can now handle, and you are saying the changes are incorrect because you are describing a different use case. |
okay, I'm content with the changes (thus far) and please feel free to do another PR if/when the second (more advanced) use case has a solution. |
Looks good. |
Describe how to run the same task multiple times.
Description of the Pull Request (PR):
Write your description of the PR here. Be sure to include as much background,
and details necessary for the reviewers to understand exactly what this is
fixing or enhancing.
This fixes or addresses the following GitHub issues:
Checkoff for all PRs:
Attn: @expfactory-admin