Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: workflow, config + typos fixed #172

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link

Checkoff for all PRs:

Attn: @expfactory-admin

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@vsoch
Copy link
Member

vsoch commented Apr 12, 2023

Thanks @yarikoptic this is very kind of you! I've been using https://crates.io/crates/typos for other projects, but it's mostly good for documentation (and not the code). I'll check out codespell if you recommend it for spelling errors in code?

For formatting, it looks like you just need black==23.3.0

@yarikoptic
Copy link
Author

Thanks @yarikoptic this is very kind of you! I've been using https://crates.io/crates/typos for other projects, but it's mostly good for documentation (and not the code).

ha -- sounds indeed very similar to codespell! never heard-of/used it though.

I'll check out codespell if you recommend it for spelling errors in code?

I am on a quest to fix typos in any project I "look at", and have used codespell for quite a number of them. In some cases "touching" hundreds of files. It does has it quirks but overall works great, and developers are responsive. My tiny helper to "codespell" a new repo is at https://github.com/yarikoptic/improveit/blob/main/codespellit .

For formatting, it looks like you just need black==23.3.0

pushed change for that.

@vsoch
Copy link
Member

vsoch commented Apr 13, 2023

@yarikoptic you have to run black locally (with that version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants