Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

use eTLD+1, not TLD #1

Merged
merged 1 commit into from
Apr 27, 2023
Merged

use eTLD+1, not TLD #1

merged 1 commit into from
Apr 27, 2023

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Apr 27, 2023

You almost certainly don't want the TLD. eTLD+1 is the only thing which really makes sense here I think.

RupertBenWiser
RupertBenWiser suggested changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@RupertBenWiser RupertBenWiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks! There's just one other spot that it also makes sense to change this.

explainer.md Show resolved Hide resolved
RupertBenWiser
RupertBenWiser approved these changes Apr 27, 2023
View reviewed changes
explainer.md Show resolved Hide resolved
@RupertBenWiser RupertBenWiser merged commit c7366e8 into explainers-by-googlers:main Apr 27, 2023
@bakkot bakkot deleted the patch-1 branch April 27, 2023 15:11
@jbruchon jbruchon mentioned this pull request Jul 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SergeyKaG SergeyKaG SergeyKaG left review comments

@michaelficarra michaelficarra michaelficarra approved these changes

@RupertBenWiser RupertBenWiser RupertBenWiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bakkot @michaelficarra @RupertBenWiser @SergeyKaG