-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added prompt class #388
Added prompt class #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good but just 2 things
- write some tests - you can write some simple tests and reflect the usecases that prompts will be used for (based on different types of prompts we have) and that would be very valuable
- no need for a module named
/prompt
just a file is enough - we are not going to subclass this right.Prompt
will only be a container for the data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing dependency langchain-core
It would be good to have a function that returns examples as str. For example:
Output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor changes, feel free to merge it after fixing it
Note: do make the CI passes before - that is important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added class RagasPrompt for creating prompt objects
- RagasPrompt.format - Will take the input parameters and returns the ChatPromptTemplate
- RagasPrompt.validate - Will check if the prompt object has the field in correct formay
Added RagasPrompt to init
Added test_prompt to test prompt object