Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up embeddings for ragas and add docs for azure embeddings #477

Merged
merged 9 commits into from Jan 19, 2024
Merged

fix: clean up embeddings for ragas and add docs for azure embeddings #477

merged 9 commits into from Jan 19, 2024

Conversation

jjmachan
Copy link
Member

@jjmachan jjmachan commented Jan 17, 2024 •
edited

  • cleanup RagasBaseEmbeddings classes
  • added documentation for AzureOpenAI

shahules786
shahules786 requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rerun this with https://huggingface.co/datasets/explodinggradients/amnesty_qa, we are trying to not use fiqa dataset anymore

@jjmachan jjmachan enabled auto-merge (squash) January 19, 2024 01:03
@jjmachan jjmachan merged commit 506ad60 into explodinggradients:main Jan 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahules786 shahules786 shahules786 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjmachan @shahules786