Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong type annotations and nonexistent types #560

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

stydxm
Copy link
Contributor

@stydxm stydxm commented Feb 6, 2024

  • The code shown in the document cause warnings in the IDE.

  • ragas.llms.LangchainLLM is no longer exists but from ragas.llms import LangchainLLM is still left in document

First time here, apology for any mistakes.

@shahules786
Copy link
Member

Hey @stydxm , thanks for the work.
@jjmachan shouldn't these classes work in ragas without explicitly wrapping LangchainLLMwrapper due to this line

@stydxm
Copy link
Contributor Author

stydxm commented Feb 6, 2024

Hey @stydxm , thanks for the work. @jjmachan shouldn't these classes work in ragas without explicitly wrapping LangchainLLMwrapper due to this line

Sorry I didn't noticed that. That PR was merged after I found this problem and start working on it yesterday 😂.
However the problem in gcp-vertexai.ipynb still exists, please allow me minutes to edit it.

@shahules786
Copy link
Member

@stydxm Thanks buddy :)

@stydxm
Copy link
Contributor Author

stydxm commented Feb 6, 2024

@stydxm Thanks buddy :)

Done

Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow thank you so much for updating this @stydxm 🙂
welcome to the contributor list 🎉

@jjmachan jjmachan merged commit e6be5bb into explodinggradients:main Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants