Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define retry arg for AsyncRetrying #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthonyivn2
Copy link

@anthonyivn2 anthonyivn2 commented Apr 3, 2024

Related to issue #839 that I made

@anthonyivn2
Copy link
Author

anthonyivn2 commented Apr 3, 2024

I just notice that seems like the exception that is passed to Tenacity is hardcoded when using OpenAI to only RateLimitError no matter the exceptions passed to RunConfig. Related code in main.

Why is this the case? Can't we assume that the user will pass the right Exception objects to RunConfig exception_types arg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant