Support asynchronous JSON RPC client with Tornado #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good thanks |
bcb
added a commit
that referenced
this pull request
Sep 9, 2016
Discovered when testing tornado in #17, the logger wasn't being configured, because tornado seems to add a root handler. Now it sets the log level if that's not configured, separate from deciding whether to add a handler.
|
This is now on pypi. The class name TornadoServer is kind of confusing, I'd be keen to hear your thoughts on changing the names (issue #19) |
|
That's good. |
bcb
added a commit
that referenced
this pull request
Sep 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #16.