missing English tokenizer exception: would've

[kwhumphreys]

add:

{ORTH: "would", NORM: "would", TAG: "MD"},

at https://github.com/explosion/spaCy/blob/master/spacy/lang/en/tokenizer_exceptions.py#L216

Your Environment

• Operating System:
  macOS 10.13.2
• Python Version Used:
  3.5.2
• spaCy Version Used:
  2.0.5
• Environment Information:

[ines]

Good catch, thanks! If you have time, feel free to submit a PR 😊

[kwhumphreys]

I have a PR but no permission to publish it

$ git push -u origin english-wouldve
remote: Permission to explosion/spaCy.git denied to kwhumphreys.
fatal: unable to access 'https://kwhumphreys@github.com/explosion/spaCy.git/': The requested URL returned error: 403

[ines]

@kwhumphreys Sorry about the late reply! The best way to submit it is to fork spaCy, push your fix to your fork and then submit it here: https://github.com/explosion/spaCy/compare (Just select your fork in the "compare" dropdown and then click "Create pull request".)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.