Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreekLemmatizer has no attribute lookup #4272

Closed
adrianeboyd opened this issue Sep 11, 2019 · 3 comments
Closed

GreekLemmatizer has no attribute lookup #4272

adrianeboyd opened this issue Sep 11, 2019 · 3 comments
Labels
bug Bugs and behaviour differing from documentation lang / el Greek language data and models

Comments

@adrianeboyd
Copy link
Contributor

How to reproduce the behaviour

import spacy
nlp = spacy.load('el')
doc = nlp.make_doc('Χθες')
print(doc[0].lemma_)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "token.pyx", line 860, in spacy.tokens.token.Token.lemma_.__get__
AttributeError: 'GreekLemmatizer' object has no attribute 'lookup'

Your Environment

  • spaCy version: 2.1.8
  • Platform: Linux-4.19.0-5-amd64-x86_64-with-debian-10.0
  • Python version: 3.7.3
@ines ines added bug Bugs and behaviour differing from documentation lang / el Greek language data and models labels Sep 11, 2019
@ines
Copy link
Member

ines commented Sep 11, 2019

Thanks! Looks like the lookup method got lost during the recent refactor. I'll add this back.
Edit: I'm confused how this ever worked, because it looks like the greek lemmatizer never had a lookup method...

@ines ines closed this as completed in 8f9f48b Sep 11, 2019
@adrianeboyd
Copy link
Contributor Author

It probably never worked.

Wouldn't it be better to have GreekLemmatizer extend Lemmatizer? I think that was the original problem.

class GreekLemmatizer(Lemmatizer):

@lock
Copy link

lock bot commented Oct 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and behaviour differing from documentation lang / el Greek language data and models
Projects
None yet
Development

No branches or pull requests

2 participants