HFShim: support MPS device #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, two devices and map locations were supported: - CUDA: `cuda:N` - CPU: `cpu` This change adds support for Metal Performance Shader (MPS) devices. In the case of MPS, the map location for loading a model is `cpu`, so we use: - CUDA: device: `cuda:N`, map location: `cuda:N` - MPS: device: `mps`, map location: `cpu` - CPU: device: `cpu`, map location: `cpu`
svlandeg
reviewed
Jun 10, 2022
|
I think we also need a dev version of spaCy to get the right Thinc version for this PR. |
|
Can this be done soon after the v3.4.0 release instead? It's not going to break anything in |
That would work. It shouldn't break anything, just moving models to the right device in a more generic manner. |
This version is required to get Torch device support from Thinc 8.1.0.
|
Set the minimum spaCy version to 3.4.0 and merged in master. This is now ready for review. |
|
@explosion-bot please test_gpu |
URL: https://buildkite.com/explosion-ai/spacy-transformers-gpu-test-suite/builds/19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, two devices and map locations were supported:
cuda:NcpuThis change adds support for other devices like Metal Performance Shader (MPS) devices by mapping to the active Torch device.