New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for textcat CNN issue #357
Conversation
EDIT: This comment belongs on the Thinc PR, so I have posted it there as well. I would like someone more familiar with the resizable layer to look at this, but I believe the current fix is correct. To clarify what's going on: Before this PR, the layer is assumed to be initialized if After this PR, the resizable layer is considered uninitialized if either |
I made one small change, so close/reopening to trigger tests... |
This reverts commit cdf122e.
@explosion-bot please test_slow_gpu --thinc-branch refs/pull/820/head |
🚨 ErrorsCommand |
@explosion-bot please test_gpu --thinc-branch refs/pull/820/head |
URL: https://buildkite.com/explosion-ai/spacy-transformers-gpu-test-suite/builds/21 |
With the branch change reverted, the non-buildkite builds are failing as expected. The buildkite build is failing with an error that there's no such module as |
@explosion-bot please test_gpu --thinc-branch refs/pull/820/head |
URL: https://buildkite.com/explosion-ai/spacy-transformers-gpu-test-suite/builds/22 |
@explosion-bot please test_gpu --thinc-branch refs/pull/820/head |
URL: https://buildkite.com/explosion-ai/spacy-transformers-gpu-test-suite/builds/23 |
Because this relies on a particular Thinc branch, the Azure tests are failing, but the Buildkite test using the proper Thinc branch has succeeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the small comment, this looks good. We'll need to release Thinc and bump its lower pin here so the CI goes green. Then we can get this merged and published.
It feels a little weird to change the spacy requirement for the package just because of a test, so maybe instead we can have the test restricted to |
Nice solution, Adriane! 🙏 |
This is a test demonstrating the issue in explosion/spaCy#11968. A potential fix is being worked on in explosion/thinc#820.
In its current condition, the test just creates a pipeline with textcat and transformer, creates a minimal doc and calls
nlp.initialize
. As described in the spaCy issue, that fails with this error:This will be left in draft until the fix is clarified.