Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.json to sample versionrc.js #3

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

awinograd
Copy link
Contributor

If versionrc.js is present, package.json isn't automatically bumped unless it's included in the versionrc.json config

Thanks for the plugin! I've been enjoying it

If versionrc.js is present, package.json isn't automatically bumped unless it's included in the versionrc.json config
@byCedric
Copy link
Member

Oh damn, I'm sorry! Thanks for fixing it ❤️ No problem, happy to hear it's working for you 😄

@byCedric byCedric merged commit 1a28eeb into expo-community:master Feb 11, 2020
@byCedric
Copy link
Member

I also updated the dev.to guide, with some credits ofc on the bottom and the first .versionrc.js example! Again, thanks for the PR, you are awesome!

@awinograd awinograd deleted the patch-1 branch February 12, 2020 04:15
@awinograd
Copy link
Contributor Author

Very kind of you to credit me! Thanks again for the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants