Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive mode with keyboard commands #326

Merged
merged 11 commits into from
Jul 28, 2017
Merged

Add interactive mode with keyboard commands #326

merged 11 commits into from
Jul 28, 2017

Commits on Jul 24, 2017

  1. Implement interactive mode with keyboard commands

    @fson
    fson committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    078cedc View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2017

  1. Ask people to reopen the app when toggling dev mode 

    This is currently required for the change to take effect,
see: expo/expo#413
    @fson
    fson committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    1f4ede5 View commit details
    Browse the repository at this point in the history

  2. Condense instructions to take less vertical space

    @fson
    fson committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    e8bb710 View commit details
    Browse the repository at this point in the history

  3. Hide the iOS emulator option on Windows

    @fson
    fson committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    c1eb74a View commit details
    Browse the repository at this point in the history

  4. Highlight the 'R' keyboard shortcut

    @fson
    fson committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    b672aba View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2017

  1. Add --no-interactive CLI argument to disable the interactive mode 

    `npm start -- --no-interactive` runs the server without interactivity.
    @fson
    fson committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    644c8eb View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2017

  1. Fix interactive mode input on Windows 

    The `readline` setup on Windows that nicely suppresses the annoying
"Terminate batch job (Y/N)" prompt when pressing Ctrl+c also caused
the keyboard commands on interactive mode to be printed to stdout.
Fix this by piping the `readline` output to a MuteStream.
    @fson
    fson committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    587e5b8 View commit details
    Browse the repository at this point in the history

  2. Stop the packager gracefully when exiting interactive mode

    @fson
    fson committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    c7251df View commit details
    Browse the repository at this point in the history

  3. Format new code with Prettier

    @fson
    fson committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    113769d View commit details
    Browse the repository at this point in the history

  4. Do not create a readline interface in the interactive mode 

    Creating the readline interface on Windows to listen for Ctrl+c caused
the text "Stopping packager" to be printed twice. In the interactive
mode stopping the packager is handled by the keypress listener set
by the interactive mode, so the readline interface is not necessary.
    @fson
    fson committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    38b5126 View commit details
    Browse the repository at this point in the history

  5. Fix bold text style bleeding outside the bold text part on Windows 

    Work around the bold style not being closed on Windows by adding reset
styles after each bold style.
    @fson
    fson committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    6ab50e8 View commit details
    Browse the repository at this point in the history