Remove jest-expo plugin on eject and use jest-react-native instead #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Nov 15, 2017
|
|
||
| pkgJson.scripts.start = 'react-native start'; | ||
| pkgJson.scripts.ios = 'react-native run-ios'; | ||
| pkgJson.scripts.android = 'react-native run-android'; | ||
|
|
||
| pkgJson.jest.preset = 'react-native'; |
There was a problem hiding this comment.
I think this is probably fine in 99.9% of the cases, but since we are here making changes, maybe we want to verify that the preset is set to "jest-expo" before we change it. if it is not, then we might want to skip the change and warn the user
There was a problem hiding this comment.
@brentvatne sounds good! What information would you add in this warning? I don't have any idea)
There was a problem hiding this comment.
Warning: it looks like you've changed the Jest preset from jest-expo to ${pkjJson.jest.preset}. We recommend you make sure this Jest preset is compatible with ejected apps.
Something like that?
KELiON
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #47
When I run
npm run ejectand try to run jest tests bynpm test, it fails withCannot find module 'expo' from 'setup.js'. So we have to remove expo jest preset and use react-native instead.I'm not sure if it is ok to replace it with
jest-react-nativefor everyone but in my case removingjest-expoand usingjest-react-nativefixed the issue