Activating Open Collective #569
Conversation
There was a problem hiding this comment.
Thanks for the PR @monkeywithacupcake! The badge looks good to me, but I'd be more comfortable not adding the postinstall hook at this point.
| @@ -1,9 +1,17 @@ | |||
| { | |||
| "private": true, | |||
| "scripts": { | |||
| "format": "prettier --single-quote --trailing-comma=es5 --print-width=100 --write '{create-react-native-app,react-native-scripts}/{src,template}/**/*.js'" | |||
| "format": "prettier --single-quote --trailing-comma=es5 --print-width=100 --write '{create-react-native-app,react-native-scripts}/{src,template}/**/*.js'", | |||
| "postinstall": "opencollective postinstall" | |||
There was a problem hiding this comment.
The postinstall script would have to go in ./create-react-native-app/package.json (not the internal package.json at the root) or it won't be triggered when people install the package.
Also the message that's shown when I run Yarn looks a bit messy / badly aligned :
If the postinstall script is optional, maybe we could just leave it out for now?
There was a problem hiding this comment.
The post install is not ideal for all repos - especially if you think that your repo will be bundled in another, users will see it every time. You can ignore or roll your own.
One user made a lighter version of the post install: https://github.com/WebReflection/lightercollective
You can also remove the dependency altogether: https://github.com/remy/nodemon/blob/master/package.json#L42
|
Thanks! I've merged the changes to README. |
Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/create-react-native-app ❤️
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a
postinstallscript to let people know afternpm|yarn installthat you are welcoming donations (optional). [More info]You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets
P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).
Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊
Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!