Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlined process typings causing conflicts #16

Closed
sdacunha opened this issue Dec 28, 2023 · 1 comment · Fixed by #17
Closed

Inlined process typings causing conflicts #16

sdacunha opened this issue Dec 28, 2023 · 1 comment · Fixed by #17

Comments

@sdacunha
Copy link

Hi, appreciate the teams work setting up these dev plugins - it has helped our transition away from Flipper.

One issue however, is that since the process env definitions were inlined, we are getting failures in CI such as these:
Screenshot 2023-12-28 at 5 23 52 PM

Here is the offending type definition:
https://github.com/expo/dev-plugins/blame/917d64066815e8cdc0b59641bae44b4abc07c0ca/packages/apollo-client/src/index.ts#L1

With the changes to how environment variables are loaded out of the box in SDK 49, this may cause issues for other users and I wanted to help them avoid spending hours trying to find the source of the error.

I currently patch the library by including @types/node and including it in the tsconfig.

@sdacunha sdacunha changed the title Process typings causing conflicts Inlined process typings causing conflicts Dec 28, 2023
@Kudo Kudo closed this as completed in #17 Dec 29, 2023
Kudo added a commit that referenced this issue Dec 29, 2023
# Why

fixes #16 

# How

rather than declare inline types, just ignore the errors since we just
use `process.env.NODE_ENV` once.
@Kudo
Copy link
Collaborator

Kudo commented Dec 29, 2023

thanks for reporting the issue. please try out @dev-plugins/apollo-client@0.0.5 and let me know whether it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants