[async-storage]: Fix inline editing cursor jump #36
Conversation
|
@jthoward64 could you help to review the change when you get a chance? |
| }; | ||
| }, | ||
| shouldCellUpdate(record, prevRecord) { | ||
| return record.editedValue !== prevRecord.editedValue; | ||
| shouldCellUpdate() { | ||
| return false; | ||
| }, | ||
| }, | ||
| { |
There was a problem hiding this comment.
| }; | |
| }, | |
| shouldCellUpdate(record, prevRecord) { | |
| return record.editedValue !== prevRecord.editedValue; | |
| shouldCellUpdate() { | |
| return false; | |
| }, | |
| }, | |
| { | |
| onBlur() { | |
| setEditingManually(false); | |
| }, | |
| onFocus() { | |
| setEditingManually(true); | |
| }, | |
| }; | |
| }, | |
| shouldCellUpdate(record, prevRecord) { | |
| return !editingManually && record.editedValue !== prevRecord.editedValue | |
| }, | |
| }, |
I added a state to check whether the user currently has focused the cell and that does seem to fix the jump issue while still keeping the json editor working. (Come to think of it this could probably be a ref instead of state, but it probably doesn't matter)
There was a problem hiding this comment.
My bad, I didn't realize my change would break the json editor. I'll merge in this suggestion!
There was a problem hiding this comment.
I've updated the pr, like you said the json editor seems to be working now.
There was a problem hiding this comment.
I've updated the pr, like you said the json editor seems to be working now.
In that case this looks good to me, so long as @Kudo doesn't have any issues
|
If this isn't going to be merged I'm willing to pull out the async storage plugin and maintain it myself |
|
thanks @Thomas-Gallant and @jthoward64 for helping this change. i'm merging the pr and publish updates soon. |
When attempting to update a value through async storage devtools UI, the cursor is moved to the beginning of the text input.
This change disables re-rendering of the Value column cells as the user is typing. This issue no longer appears, and functionality of saving changes, adding and removing key-value pairs does not appear to be affected by this change.
Fixes #23