[eas submit][ios] no app icon error message needs improvement

[EvanBacon]

The output when an icon is missing is messy and could be improved.

tape-warm 𝝠 easd submit
✔ Choose a platform to submit to › iOS
✔ Ensuring @bacon/tape-warm is created on Expo

Ensuring your app exists on App Store Connect. This step can be skipped by providing the --asc-app-id
param. Learn more: https://expo.fyi/asc-app-id

Please enter your Apple Developer Program account credentials. These credentials are needed to manage
certificates, keys and provisioning profiles in your Apple Developer account.
The password is only used to authenticate with Apple and never stored on Expo servers
Learn more here https://docs.expo.io/distribution/security/#apple-developer-account-credentials
✔ Apple ID: … evanjbacon@gmail.com
Using password from your local Keychain. Learn more https://docs.expo.io/distribution/security#keychain
Restoring session /Users/evanbacon/.app-store/auth/evanjbacon@gmail.com/cookie
Logged in Local session restored

Ensuring that bundle ID "org.name.tapewarm" is registered on Apple Dev Center...
Checking App Store Connect for "tape-warm" (org.name.tapewarm)...
Creating app "tape-warm" (org.name.tapewarm) on App Store Connect...
App "tape-warm" (org.name.tapewarm) on App Store Connect is ready for your binary.
✔ What would you like to submit? › The latest build from Expo servers
┌─────────────────────────────────────────────────────────────────────────────────┐
│                             iOS Submission Summary                              │
├─────────────────────────┬───────────────────────────────────────────────────────┤
│ Archive URL             │ https://turtle-v2-artifacts.s3.amazonaws.com/ios/7    │
│                         │ 9a38488-7eb9-4ebc-9728-f02a842cc887-6eee499fda774f    │
│                         │ 98847316edbfcc541b.ipa                                │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Apple ID                │ evanjbacon@gmail.com                                  │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Apple app-specific      │ [hidden]                                              │
│ password                │                                                       │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│  App Store Connect App  │ 1543439387                                            │
│ ID                      │                                                       │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Project ID              │ cab65372-b7f1-4448-96af-00061fa92cae                  │
└─────────────────────────┴───────────────────────────────────────────────────────┘
✔ Scheduling submission
✖ Something went wrong when submitting your app to Apple App Store.
Please see logs

[logs] Starting iOS app upload
[logs] Downloading archive
[logs] Uploading iOS app to TestFlight...
[logs] [09:35:48]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[logs] [09:35:50]: -------------------
[logs] [09:35:50]: --- Step: pilot ---
[logs] [09:35:50]: -------------------
[logs] [09:35:50]: Ready to upload new build to TestFlight (App: 1543439387)...
[logs] [09:35:53]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
[logs] [09:35:53]: Going to upload updated app to App Store Connect
[logs] [09:35:53]: This might take a few minutes. Please don't interrupt the script.
[logs] [09:37:12]: [Transporter Error Output]: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface"
[logs] [09:37:12]: [Transporter Error Output]: ERROR ITMS-90713: "Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'org.name.tapewarm'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7."
[logs] [09:37:12]: [Transporter Error Output]: ERROR ITMS-90704: "Missing App Icon. An app icon measuring 1024 by 1024 pixels in PNG format must be included in the Asset Catalog of apps built for iOS, iPadOS, or watchOS. Without this icon, apps cannot be submitted for review. For details, see https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/."
[logs] [09:37:12]: Transporter transfer failed.
[logs] [09:37:12]: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface"
[logs] ERROR ITMS-90713: "Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'org.name.tapewarm'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7."
[logs] [09:37:12]: 
[logs] ERROR ITMS-90704: "Missing App Icon. An app icon measuring 1024 by 1024 pixels in PNG format must be included in the Asset Catalog of apps built for iOS, iPadOS, or watchOS. Without this icon, apps cannot be submitted for review. For details, see https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/."
[logs] [09:37:12]: [iTMSTransporter] [2020-12-04 09:37:12 PST] <main> ERROR: ERROR ITMS-90713: "Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'org.name.tapewarm'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7."
[logs] [09:37:12]: [iTMSTransporter] [2020-12-04 09:37:12 PST] <main> ERROR: ERROR ITMS-90704: "Missing App Icon. An app icon measuring 1024 by 1024 pixels in PNG format must be included in the Asset Catalog of apps built for iOS, iPadOS, or watchOS. Without this icon, apps cannot be submitted for review. For details, see https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/."
[logs] 
[logs] [09:37:12]: [iTMSTransporter] [2020-12-04 09:37:12 PST] <main> DBG-X: The error code is: 1102
[logs] 
[logs] [09:37:12]: [iTMSTransporter] [2020-12-04 09:37:12 PST] <main>  INFO: Done performing authentication.
[logs] 
[logs] [09:37:12]: [iTMSTransporter]
[logs] [09:37:12]: [iTMSTransporter] 
[logs] 
[logs] [09:37:12]: [iTMSTransporter] 
[logs] 
[logs] [09:37:12]: [iTMSTransporter] Package Summary:
[logs] 
[logs] [09:37:12]: [iTMSTransporter]  
[logs] 
[logs] [09:37:12]: [iTMSTransporter] 1 package(s) were not uploaded because they had problems:
[logs] 
[logs] [09:37:12]: [iTMSTransporter] 	/var/folders/97/73j93h690g9gdn54bh_zskm40000gn/T/d20201204-82539-1mwei59/1543439387.itmsp - Error Messages:
[logs] 
[logs] [09:37:12]: [iTMSTransporter] 		ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface"
[logs] 
[logs] [09:37:12]: [iTMSTransporter] 		ERROR ITMS-90713: "Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'org.name.tapewarm'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7."
[logs] 
[logs] [09:37:12]: [iTMSTransporter] 		ERROR ITMS-90704: "Missing App Icon. An app icon measuring 1024 by 1024 pixels in PNG format must be included in the Asset Catalog of apps built for iOS, iPadOS, or watchOS. Without this icon, apps cannot be submitted for review. For details, see https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/."
[logs] 
[logs] [09:37:12]: [iTMSTransporter] [2020-12-04 09:37:12 PST] <main> DBG-X: Returning 1
[logs] 
[logs] [09:37:12]: iTunes Transporter output above ^
[logs] [09:37:12]: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface"
[logs] ERROR ITMS-90713: "Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'org.name.tapewarm'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7."
[logs] ERROR ITMS-90704: "Missing App Icon. An app icon measuring 1024 by 1024 pixels in PNG format must be included in the Asset Catalog of apps built for iOS, iPadOS, or watchOS. Without this icon, apps cannot be submitted for review. For details, see https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/."
[logs] Return status of iTunes Transporter was 1: ERROR ITMS-90022: "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_inter\nERROR ITMS-90713: "Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'org.name.tapewarm'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for t\nERROR ITMS-90704: "Missing App Icon. An app icon measuring 1024 by 1024 pixels in PNG format must be included in the Asset Catalog of apps built for iOS, iPadOS, or watchOS. Without this icon, apps cannot be submitted for review. For details, see https://developer.apple.com/ios/human-interface-guidelines/icons-and-images/app-icon/."
[logs] The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
[logs] [!] Error uploading ipa file, for more information see above
[logs] fastlane pilot failed

[EvanBacon]

Another one for redundant binary upload:

gungeon-guide 𝝠 eas submit
✔ Choose a platform to submit to › iOS
✔ Ensuring @bacon/gungeon-guide is created on Expo

Ensuring your app exists on App Store Connect. This step can be skipped by
providing the --asc-app-id param. Learn more:
https://expo.fyi/asc-app-id

Please enter your Apple Developer Program account credentials. These
credentials are needed to manage certificates, keys and provisioning profiles
in your Apple Developer account.
The password is only used to authenticate with Apple and never stored on
Expo servers
Learn more here
https://docs.expo.io/distribution/security/#apple-developer-account-credentials
✔ Apple ID: … evanjbacon@gmail.com
Using password from your local Keychain. Learn more https://docs.expo.io/distribution/security#keychain
Restoring session /Users/evanbacon/.app-store/auth/evanjbacon@gmail.com/cookie
Logged in Local session restored

Ensuring that bundle ID "com.bacon.gungeonguide" is registered on Apple Dev Center...
Checking App Store Connect for "Gungeon Guide" (com.bacon.gungeonguide)...
App "Gungeon Guide" (com.bacon.gungeonguide) on App Store Connect is ready for your binary.
✔ What would you like to submit? › The latest build from Expo servers
┌─────────────────────────────────────────────────────────────────────────────────┐
│                             iOS Submission Summary                              │
├─────────────────────────┬───────────────────────────────────────────────────────┤
│ Archive URL             │ https://turtle-v2-artifacts.s3.amazonaws.com/ios/e    │
│                         │ 3894d93-8cc4-4aff-890e-2135d40c9054-d5d287676e2c40    │
│                         │ 29a364ff577db173c9.ipa                                │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Apple ID                │ evanjbacon@gmail.com                                  │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Apple app-specific      │ [hidden]                                              │
│ password                │                                                       │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│  App Store Connect App  │ 1543232316                                            │
│ ID                      │                                                       │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Project ID              │ af63dc25-aa88-4689-ba03-a722a9e71818                  │
└─────────────────────────┴───────────────────────────────────────────────────────┘
✔ Scheduling submission
✖ Something went wrong when submitting your app to Apple App Store.
iOS build number needs to be updated

[logs] Starting iOS app upload
[logs] Downloading archive
[logs] Uploading iOS app to TestFlight...
[logs] [12:14:42]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[logs] [12:14:44]: -------------------
[logs] [12:14:44]: --- Step: pilot ---
[logs] [12:14:44]: -------------------
[logs] [12:14:44]: Ready to upload new build to TestFlight (App: 1543232316)...
[logs] [12:14:47]: Fetching password for transporter from environment variable named `FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD`
[logs] [12:14:47]: Going to upload updated app to App Store Connect
[logs] [12:14:47]: This might take a few minutes. Please don't interrupt the script.
[logs] [12:15:27]: [Transporter Error Output]: ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4)."
[logs] [12:15:27]: Transporter transfer failed.
[logs] [12:15:27]: 
[logs] [12:15:27]: ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4)."
[logs] [12:15:27]: [iTMSTransporter] [2020-12-04 12:15:27 PST] <main> DBG-X:   parameter ErrorMessage = ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4).
[logs] [12:15:27]: [iTMSTransporter]  (1102)
[logs] 
[logs] [12:15:27]: [iTMSTransporter] [2020-12-04 12:15:27 PST] <main> DBG-X:   parameter ShouldUseRESTAPIs = false
[logs] 
[logs] [12:15:27]: [iTMSTransporter] [2020-12-04 12:15:27 PST] <main> ERROR: ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4)."
[logs] [12:15:27]: [iTMSTransporter] [2020-12-04 12:15:27 PST] <main> DBG-X: The error code is: 1102
[logs] 
[logs] [12:15:27]: [iTMSTransporter] [2020-12-04 12:15:27 PST] <main>  INFO: Done performing authentication.
[logs] 
[logs] [12:15:27]: [iTMSTransporter] 
[logs] 
[logs] [12:15:27]: [iTMSTransporter] 
[logs] 
[logs] [12:15:27]: [iTMSTransporter] 
[logs] 
[logs] [12:15:27]: [iTMSTransporter] Package Summary:
[logs] 
[logs] [12:15:27]: [iTMSTransporter]
[logs] [12:15:27]: [iTMSTransporter] 1 package(s) were not uploaded because they had problems:
[logs] 
[logs] [12:15:27]: [iTMSTransporter] 	/var/folders/97/73j93h690g9gdn54bh_zskm40000gn/T/d20201204-83821-1fbcjql/1543232316.itmsp - Error Messages:
[logs] 
[logs] [12:15:27]: [iTMSTransporter] 		ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4)."
[logs] 
[logs] [12:15:27]: [iTMSTransporter] [2020-12-04 12:15:27 PST] <main> DBG-X: Returning 1
[logs] 
[logs] [12:15:27]: iTunes Transporter output above ^
[logs] [12:15:27]: ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4)."
[logs] Return status of iTunes Transporter was 1: ERROR ITMS-90189: "Redundant Binary Upload. You've already uploaded a build with build number '1' for version number '1.0.0'. Make sure you increment the build string before you upload your app to App Store Connect. Learn more in Xcode Help (http://help.apple.com/xcode/mac/current/#/devba7f53ad4)."
[logs] The call to the iTMSTransporter completed with a non-zero exit status: 1. This indicates a failure.
[logs] [!] Error uploading ipa file, for more information see above
[logs] fastlane pilot failed

[barthap]

I also encountered the one about icon (ERROR ITMS-90022) recently, I'm gonna add support for it (maybe a FYI page).

The second one should already be supported:
https://github.com/expo/turtle-v2/blob/31ade5dc8cf4f17877d9d4f3d7b8f6acec308659/src/services/submission-service/src/tasks/iosSubmit/execute.ts#L103
I'll look into it 🤔

[EvanBacon]

You can repro by doing the following:

• Delete the icon field in your app.config
• rm -rf ios android
• expo eject

This will cause eject to skip icon generation, leaving you with a project that needs an icon.