-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas submit] Add missing iOS error messages #125
Conversation
@@ -28,14 +32,30 @@ const SubmissionErrorMessages: Record<SubmissionErrorCode, string> = { | |||
[SubmissionErrorCode.ANDROID_MISSING_PRIVACY_POLICY]: | |||
'The app has permissions that require a privacy policy set for the app.\n' + | |||
`${learnMore('https://expo.fyi/missing-privacy-policy')}.`, | |||
[SubmissionErrorCode.IOS_OLD_VERSION_CODE_ERROR]: | |||
"You've already submitted this version of the app.\n" + | |||
'Versions are identified by Build Numbers (expo.ios.buildNumber in app.json).\n' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can link to a FYI page here instead, so it's easier to update and provide information about how to do this in managed and bare contexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, however I haven't changed this message to reflect the already-existing Android counterpart:
https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/submissions/utils/errors.ts#L23-L27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, we should follow up and change that on the android side. i think it's because we wrote the android side prior to eas-cli existing
Added a FYI page for bumping iOS version number message: expo/fyi#19 |
213f502
to
830a826
Compare
Size Change: -456 B (0%) Total Size: 42.5 MB
|
Why
Fixes #115
How
Fixed the "Redundant Binary Upload" error handling was missing in CLI
Added error handling for (https://github.com/expo/turtle-v2/pull/341):
TMS-90022
,ITMS-90704
)ITMS-90034
) - seems to happen when Distribution Cert, tied to app Provisioning Provile, is revokedTest Plan
Tested manually:
![Screenshot 2020-12-10 at 13 06 51](https://user-images.githubusercontent.com/278340/101770335-9c0f3c80-3ae8-11eb-8379-bec06dcc6b2b.png)