[eas submit] Add missing iOS error messages #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Dec 12, 2020
| @@ -28,14 +32,30 @@ const SubmissionErrorMessages: Record<SubmissionErrorCode, string> = { | |||
| [SubmissionErrorCode.ANDROID_MISSING_PRIVACY_POLICY]: | |||
| 'The app has permissions that require a privacy policy set for the app.\n' + | |||
| `${learnMore('https://expo.fyi/missing-privacy-policy')}.`, | |||
| [SubmissionErrorCode.IOS_OLD_VERSION_CODE_ERROR]: | |||
| "You've already submitted this version of the app.\n" + | |||
| 'Versions are identified by Build Numbers (expo.ios.buildNumber in app.json).\n' + | |||
There was a problem hiding this comment.
maybe we can link to a FYI page here instead, so it's easier to update and provide information about how to do this in managed and bare contexts
There was a problem hiding this comment.
Done, however I haven't changed this message to reflect the already-existing Android counterpart:
https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/submissions/utils/errors.ts#L23-L27
There was a problem hiding this comment.
ah, we should follow up and change that on the android side. i think it's because we wrote the android side prior to eas-cli existing
|
Added a FYI page for bumping iOS version number message: expo/fyi#19 |
brentvatne
force-pushed
the
@barthap/submit/messages
branch
from
213f502
to
830a826
Compare
|
Size Change: -456 B (0%) Total Size: 42.5 MB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #115
How
Fixed the "Redundant Binary Upload" error handling was missing in CLI
Added error handling for (https://github.com/expo/turtle-v2/pull/341):
TMS-90022,ITMS-90704)ITMS-90034) - seems to happen when Distribution Cert, tied to app Provisioning Provile, is revokedTest Plan
Tested manually:
