Upload project sources and submit archives to GCS #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
force-pushed
the
@wkozyra95/upload-archives-to-gcs
branch
from
75072aa
to
57f3710
Compare
|
Size Change: +2.04 kB (0%) Total Size: 40.3 MB
|
wkozyra95
force-pushed
the
@wkozyra95/upload-archives-to-gcs
branch
3 times, most recently
from
75de07d
to
5dadd29
Compare
Codecov Report
@@ Coverage Diff @@
## main #1524 +/- ##
==========================================
+ Coverage 51.48% 51.49% +0.02%
==========================================
Files 453 453
Lines 15648 15656 +8
Branches 3076 3079 +3
==========================================
+ Hits 8055 8061 +6
- Misses 7579 7581 +2
Partials 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dsokal
reviewed
Nov 16, 2022
Comment on lines
133
to
134
| resolvedArchiveSource: { type: SubmissionArchiveSourceType.Url, url }, | ||
| source, |
There was a problem hiding this comment.
Couldn't this be sth like:
Suggested change
| resolvedArchiveSource: { type: SubmissionArchiveSourceType.Url, url }, | |
| source, | |
| source: { type: SubmissionArchiveSourceType.Url, url }, |
Comment on lines
186
to
187
| resolvedArchiveSource: { type: SubmissionArchiveSourceType.GcsSubmitArchive, bucketKey }, | ||
| source, |
There was a problem hiding this comment.
And:
Suggested change
| resolvedArchiveSource: { type: SubmissionArchiveSourceType.GcsSubmitArchive, bucketKey }, | |
| source, | |
| source: { type: SubmissionArchiveSourceType.GcsSubmitArchive, bucketKey }, |
If I understand correctly, this needs another Archive... interface.
I don't think we should have two almost identical fields in the return object.
Comment on lines
+93
to
+94
| const fileStat = await fs.stat(file); | ||
| const fileSize = fileStat.size; |
There was a problem hiding this comment.
Suggested change
| const fileStat = await fs.stat(file); | |
| const fileSize = fileStat.size; | |
| const { size: fileSize } = await fs.stat(file); |
wkozyra95
commented
Nov 16, 2022
| @@ -8,7 +8,7 @@ | |||
| "build:tarballs:linux": "yarn build-for-size-check", | |||
| "build-for-size-check": "yarn build && yarn workspace eas-cli pretarball-ci && CLI_SIZE_CHECK=1 yarn workspace eas-cli oclif pack:tarballs --no-xz --targets linux-x64", | |||
| "typecheck": "lerna run typecheck", | |||
| "start": "lerna run watch --parallel", | |||
| "start": "lerna run watch --stream --parallel", | |||
There was a problem hiding this comment.
new lerna version does not show output without stream option
szdziedzic
approved these changes
Nov 16, 2022
dsokal
approved these changes
Nov 17, 2022
wkozyra95
force-pushed
the
@wkozyra95/upload-archives-to-gcs
branch
from
fe82c63
to
5bff6e7
Compare
|
/changelog-entry chore Upload project sources for EAS Build and archives for EAS Submit to GCS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]and CHANGELOG.md will be updated automatically.Why
Upload project sourced for build and ipa/aab for submits to gcs
How
Test Plan
Run build, build with auto submit, submit with path option, submit from existing build