Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] more branch map utility functions #2001

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

quinlanj
Copy link
Member

Why

extra utility function for branch mapping

Test Plan

  • new tests pass

@quinlanj
Copy link
Member Author

/changelog-entry chore more branch map utility functions

@quinlanj quinlanj marked this pull request as ready for review August 10, 2023 23:15
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Size Change: +1.72 kB (0%)

Total Size: 42.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.3 MB +1.72 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2001 (6fd7554) into main (e42ea7e) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 6fd7554 differs from pull request most recent head 3d7024d. Consider uploading reports for the commit 3d7024d to get more accurate results

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   53.04%   53.05%   +0.02%     
==========================================
  Files         507      507              
  Lines       18399    18405       +6     
  Branches     3856     3857       +1     
==========================================
+ Hits         9757     9763       +6     
  Misses       7948     7948              
  Partials      694      694              
Files Changed Coverage Δ
packages/eas-cli/src/rollout/branch-mapping.ts 94.12% <100.00%> (+0.28%) ⬆️

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One naming nit, otherwise looks good.

packages/eas-cli/src/rollout/branch-mapping.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit baf94a2 into main Aug 11, 2023
6 checks passed
@quinlanj quinlanj deleted the @quin/branchMappingUtils branch August 11, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants