Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli][eas-json] add developmentClient to metadata #2015

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

szdziedzic
Copy link
Member

Why

Add developmentClient to metadata. Companion to https://github.com/expo/universe/pull/13215.

How

Add developmentClient to metadata.

Test Plan

Test manually

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Size Change: +2.42 kB (0%)

Total Size: 42.2 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.2 MB +2.42 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2015 (78185e9) into main (6cb02d0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   53.02%   53.01%   -0.01%     
==========================================
  Files         508      508              
  Lines       18446    18451       +5     
  Branches     3869     3874       +5     
==========================================
  Hits         9780     9780              
- Misses       7971     8653     +682     
+ Partials      695       18     -677     
Files Changed Coverage Δ
packages/eas-cli/src/build/createContext.ts 22.04% <0.00%> (-2.04%) ⬇️
packages/eas-cli/src/build/metadata.ts 22.23% <ø> (ø)

... and 193 files with indirect coverage changes

@szdziedzic szdziedzic requested a review from Simek August 24, 2023 12:48
@szdziedzic
Copy link
Member Author

/changelog-entry chore Add developmentClient to metadata

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit c86550c into main Aug 25, 2023
6 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/add-development-client-to-metadata branch August 25, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants