Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add account type to project owner prompt #2083

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

alanjhughes
Copy link
Contributor

Why

Closes ENG-9850

How

Added the account type to the items when the user is asked to select a project owner. Followed a similar approach that was used on the website to categorise the accounts.

Test Plan

Tested running the cli locally against the staging environment
Screenshot 2023-10-10 at 15 56 32
Screenshot 2023-10-10 at 15 57 37

@linear
Copy link

linear bot commented Oct 10, 2023

ENG-9850 Show account type when initialising EAS project via CLI

Screenshot 2023-08-23 at 12.40.55.png

Would be nice to divide the project in groups or show the account type in the parenthesis after the name to match what we do on website:

Screenshot 2023-08-23 at 12.42.29.png

@alanjhughes alanjhughes changed the title add account type to project owner prompt [eas-cli] add account type to project owner prompt Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Size Change: +3.31 kB (0%)

Total Size: 42.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.6 MB +3.31 kB (0%)

compressed-size-action

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2083 (59623e1) into main (a56abe3) will increase coverage by 0.01%.
The diff coverage is 63.64%.

@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   54.06%   54.07%   +0.01%     
==========================================
  Files         508      508              
  Lines       18641    18669      +28     
  Branches     3722     3735      +13     
==========================================
+ Hits        10077    10094      +17     
- Misses       8544     8554      +10     
- Partials       20       21       +1     
Files Coverage Δ
packages/eas-cli/src/graphql/generated.ts 100.00% <ø> (ø)
packages/eas-cli/src/graphql/types/Account.ts 100.00% <ø> (ø)
packages/eas-cli/src/commands/project/init.ts 80.56% <63.64%> (-3.96%) ⬇️

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@alanjhughes alanjhughes merged commit 49b6e1f into main Oct 11, 2023
9 checks passed
@alanjhughes alanjhughes deleted the @alanhughes/account-types branch October 11, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants