[expo-updates] Gate roll back to embedded to expo-updates >= 0.19.0 #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
requested review from
EvanBacon,
byCedric,
szdziedzic and
khamilowicz
as code owners
wschurman
requested review from
quinlanj
and removed request for
byCedric,
khamilowicz,
EvanBacon and
szdziedzic
|
Size Change: +2.6 kB (0%) Total Size: 42.6 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2094 +/- ##
==========================================
+ Coverage 54.07% 54.09% +0.02%
==========================================
Files 508 508
Lines 18674 18681 +7
Branches 3934 3936 +2
==========================================
+ Hits 10097 10104 +7
Misses 7886 7886
Partials 691 691
|
|
/changelog-entry new-feature Gate roll back to embedded to expo-updates >= 0.19.0 |
1 similar comment
|
/changelog-entry new-feature Gate roll back to embedded to expo-updates >= 0.19.0 |
wschurman
force-pushed
the
@wschurman/eas-update-version
branch
from
9e88b0f
to
e963f6a
Compare
|
/changelog-entry new-feature Gate roll back to embedded to expo-updates >= 0.19.0 |
|
✅ Thank you for adding the changelog entry! |
quinlanj
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This feature wasn't officially added and tested until 0.19.0. It still hasn't been fully dogfooded or documented, but should theoretically be ready to release as of 0.19.0.
We can always change this in the future to something higher if we find bugs.
How
Add condition to running the command and also release commands publicly.
Test Plan
Run new tests.