Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-10922][eas-json] add new Xcode 15.1 image to eas.schema.json #2155

Merged

Conversation

szdziedzic
Copy link
Member

Why

We are adding Xcode 15.1 image

How

Add new Xcode 15.1 image to eas.schema.json

Test Plan

Tests

@szdziedzic
Copy link
Member Author

/changelog-entry chore Add new Xcode 15.1 image to eas.schema.json

Copy link

github-actions bot commented Dec 15, 2023

Size Change: +435 B (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB +435 B (0%)

compressed-size-action

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43180c0) 54.20% compared to head (b10975e) 54.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2155   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files         509      509           
  Lines       18657    18657           
  Branches     3736     3736           
=======================================
  Hits        10112    10112           
  Misses       8524     8524           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. @brentvatne, do we need to post a changelog about upcoming default change from macos-ventura-13.4-xcode-14.3.1 to macos-ventura-13.6-xcode-15.0?

@szdziedzic szdziedzic changed the title [eas-json] add new Xcode 15.1 image to eas.schema.json [ENG-10922][eas-json] add new Xcode 15.1 image to eas.schema.json Dec 15, 2023
Copy link

linear bot commented Dec 15, 2023

@brentvatne
Copy link
Member

Changes look good to me. @brentvatne, do we need to post a changelog about upcoming default change from macos-ventura-13.4-xcode-14.3.1 to macos-ventura-13.6-xcode-15.0?

@szdziedzic and i discussed this a bit today. were you referring to the "explicit default" case (where someone specifies "image": "default") here?

@szdziedzic szdziedzic force-pushed the @szdziedzic/add-new-xcode-15.1-image-to-eas-schema-json branch from b10975e to c710b22 Compare December 19, 2023 12:01
@szdziedzic szdziedzic merged commit 7e74829 into main Dec 19, 2023
4 of 5 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/add-new-xcode-15.1-image-to-eas-schema-json branch December 19, 2023 12:02
Copy link

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants