Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S3 archive support #2165

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Remove S3 archive support #2165

merged 3 commits into from
Jan 5, 2024

Conversation

sjchmiela
Copy link
Contributor

Why

x-ref expo/eas-build#302

How

Upgraded @expo/eas-build-job and fixed the only TS error.

Test Plan

None.

Copy link

github-actions bot commented Jan 5, 2024

Size Change: -3.32 kB (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB -3.32 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eeb143a) 54.21% compared to head (3e72318) 54.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/eas-cli/src/build/graphql.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2165      +/-   ##
==========================================
+ Coverage   54.21%   54.22%   +0.01%     
==========================================
  Files         509      509              
  Lines       18670    18668       -2     
  Branches     3741     3740       -1     
==========================================
  Hits        10121    10121              
+ Misses       8528     8526       -2     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela marked this pull request as ready for review January 5, 2024 10:01
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 5, 2024

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela merged commit 0aea5a3 into main Jan 5, 2024
9 checks passed
@sjchmiela sjchmiela deleted the stanley/remove-s3 branch January 5, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants