Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-10799][ci][eas-cli][eas-json] test against node 20 and drop support for node 14 #2175

Merged

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Jan 11, 2024

Why

Node 14 is no longer maintained, Node 20 is the current active

Similar to #1098

How

Test against Node 20, make it the default Node version used to work with EAS CLI.

Drop support for Node 14, it's not maintained for a longer while (even 16 is not maintained anymore). Changing the engines value to 14.0.0 will make it fail for the people trying to install EAS CLI when using Node 14.

Questions

Do we want to announce this change publicly or there is no need for additional communication (Maybe because of the reasons similar to #1098 (review)?) and we can just release it? It will make people using Node 14 unable to install new EAS versions.

End of life date for Node 14 was April 30, 2023.

Test Plan

Tests, test manually using Node 20

@szdziedzic szdziedzic changed the title [ci][eas-cli][eas-json] test against node 20 and drop support for node 14 [ENG-10799][ci][eas-cli][eas-json] test against node 20 and drop support for node 14 Jan 11, 2024
Copy link

linear bot commented Jan 11, 2024

Copy link

github-actions bot commented Jan 11, 2024

Size Change: -2.27 kB (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB -2.27 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1fd4e8) 54.22% compared to head (56d1980) 54.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2175   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files         509      509           
  Lines       18668    18668           
  Branches     3740     3740           
=======================================
  Hits        10121    10121           
  Misses       8526     8526           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic marked this pull request as ready for review January 11, 2024 12:52
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we let users know that there's a newer eas-cli available if they're running an older version? If so, I think I'm ok with bumping major version, since it's a breaking change, and not doing any more communication. I'm also open to other solutions.

@szdziedzic
Copy link
Member Author

Do we let users know that there's a newer eas-cli available if they're running an older version?

yes

@szdziedzic
Copy link
Member Author

/changelog-entry breaking-change Drop support for Node 14

Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 14dd3d2 into main Jan 12, 2024
10 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/use-node-20-in-tests-drop-support-for-node-14 branch January 12, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants