Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] remove old Xcode images entirerly #2438

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

szdziedzic
Copy link
Member

Why

These images were removed

How

Remove any mentions of them

Test Plan

tests

Copy link

github-actions bot commented Jun 17, 2024

Size Change: -1.08 kB (0%)

Total Size: 52 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52 MB -1.08 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.46%. Comparing base (230e364) to head (23616c6).

Current head 23616c6 differs from pull request most recent head 10b1991

Please upload reports for the commit 10b1991 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2438      +/-   ##
==========================================
+ Coverage   53.46%   53.46%   +0.01%     
==========================================
  Files         530      530              
  Lines       19511    19505       -6     
  Branches     3968     3965       -3     
==========================================
- Hits        10429    10427       -2     
+ Misses       8330     8327       -3     
+ Partials      752      751       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic force-pushed the @szdziedzic/remove-old-xcode-images-entirerly branch from 23616c6 to 10b1991 Compare June 18, 2024 08:51
Copy link

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit bd0a696 into main Jun 18, 2024
5 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/remove-old-xcode-images-entirerly branch June 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants