[eas-json] Detect dependency cycle for build profiles #283

wkozyra95 · 2021-03-22T09:39:15Z

Checklist

I've added an entry to CHANGELOG.md if necessary.

Why

Detecting deps cycle does not work

How

delete buildProfile.extends was removing extends keyword on first read fo a profile and by doing that it also removed cycle

Test Plan

“override”: {
  “workflow”: “generic”,
  “extends”: “override”,

eas build

github-actions · 2021-03-22T09:42:06Z

Size Change: +1.02 kB (0%)

Total Size: 32.8 MB

Filename	Size	Change
`./packages/eas-cli/dist/eas-linux-x64.tar.gz`	32.8 MB	+1.02 kB (0%)

_{compressed-size-action}

dsokal · 2021-03-22T09:42:50Z

packages/eas-json/src/EasJsonReader.ts

@@ -150,15 +150,14 @@ export class EasJsonReader {
    if (!buildProfile) {
      throw new Error(`There is no profile named ${buildProfileName} for platform ${platform}`);
    }
-    const baseProfileName = buildProfile.extends;
-    delete buildProfile.extends;
+    const { extends: baseProfileName, ...overrideBuildProfile } = buildProfile;


override is a verb. Maybe sth like rest, buildProfileRest, ...?

[eas-json] Detect dependency cycle for build profiles

b69c709

wkozyra95 requested a review from dsokal March 22, 2021 09:39

dsokal suggested changes Mar 22, 2021

View reviewed changes

Update CHANGELOG.md

b747d3b

wkozyra95 requested a review from dsokal March 22, 2021 09:44

review feedback

34b35e5

dsokal approved these changes Mar 22, 2021

View reviewed changes

wkozyra95 merged commit b6c300b into main Mar 22, 2021

wkozyra95 deleted the @wkozyra95/fix-detecting-dependency-cycle-for-eas-json branch March 22, 2021 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[eas-json] Detect dependency cycle for build profiles #283

[eas-json] Detect dependency cycle for build profiles #283

wkozyra95 commented Mar 22, 2021 •

edited

github-actions bot commented Mar 22, 2021 •

edited

dsokal Mar 22, 2021

[eas-json] Detect dependency cycle for build profiles #283

[eas-json] Detect dependency cycle for build profiles #283

Conversation

wkozyra95 commented Mar 22, 2021 • edited

Checklist

Why

How

Test Plan

github-actions bot commented Mar 22, 2021 • edited

dsokal Mar 22, 2021

Choose a reason for hiding this comment

wkozyra95 commented Mar 22, 2021 •

edited

github-actions bot commented Mar 22, 2021 •

edited