[eas-cli] Add AppStore app creation to submission command #65

barthap · 2020-11-13T06:58:59Z

Added App Store Connect app creation, currently still depending on traveling-fastlane

Command flow

This is how the command flow currently works:

Login to EAS + Ensure Expo project exists
Ensure app exists on Apple Developer + App Store Connect

This step can be skipped if provided --app-apple-id flag directly. This lets users omit the whole client-side login to Apple
- Resolve appName and bundleIdentifier from flags first, then from app.json, eventually prompt
- Login to Apple (normal 2FA login),
- Resolve App Store Connect Team ID
- Create app on Apple Dev + App Store Connect (does nothing if already exists)
[only if step 2 is skipped] Resolve Apple ID (from flag or prompt)
Resolve archive source: build id/path/url
Resolve appSpecificPassword (from env var or prompt)
Send request to Submission Service. The request payload is:

{
   appleId,
   appAppleId,
   archiveUrl,
   appSpecificPassword
}

Example output

Click to expand

./bin/run submit --platform=ios --app-name="Hello World"
✔ Ensuring project @barthap10/hello-world is registered on Expo servers

Ensuring your app exists on App Store Connect. This step can be skipped by providing the --app-apple-id flag

Please enter your iOS bundle identifier.
You can also specify ios.bundleIdentifier in app.json file
✔ Bundle Identifier:  … barthap.HelloWorld
Please enter your Apple Developer Program account credentials. These credentials are needed to manage certificates, keys and provisioning profiles in your Apple Developer account.
The password is only used to authenticate with Apple and never stored on Expo servers
Learn more here https://docs.expo.io/distribution/security/#apple-developer-account-credentials
✔ Apple ID: … my-apple-id@icloud.com
Using password from your local Keychain. Learn more https://docs.expo.io/distribution/security#keychain
Authenticating to Apple Developer Portal...
Authenticated with Apple Developer Portal successfully!
You have 4 teams associated with your account
✔ Which team would you like to use? › … 3) XX11ABC22Z "My Awesome Team" (Individual)
Resolving your App Store Connect team...
Ensuring the app exists on App Store Connect, this may take a while...

+----------------+----------------------------+
|         Summary for produce 2.146.1         |
+----------------+----------------------------+
| app_identifier | barthap.HelloWorld         |
| app_name       | Hello World                |
| username       | my-apple-id@icloud.com     │ 
| language       | English                    |
| sku            | 165432107                  |
| platform       | ios                        |
| skip_itc       | false                      |
| skip_devcenter | false                      |
+----------------+----------------------------+

[09:55:09]: [DevCenter] App 'barthap.HelloWorld' already exists, nothing to do on the Dev Center
[09:55:13]: App 'barthap.HelloWorld' already exists (1234567894), nothing to do on App Store Connect
✔ What would you like to submit? › The latest build from Expo servers
✔ Your Apple app-specific password: xxxxxxx-xxxxxxx
┌─────────────────────────────────────────────────────────────────────────────────┐
│                             iOS Submission Summary                              │
├─────────────────────────┬───────────────────────────────────────────────────────┤
│ Archive URL             │ http://link.to/turtle-v2-artifact                     │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Apple ID                │ my-apple-id@icloud.com                                │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Apple app-specific      │ [hidden]                                              │
│ password                │                                                       │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│  App Store Connect App  │ 1234567894                                            │
│ ID number               │                                                       │
├─────────────────────────┼───────────────────────────────────────────────────────┤
│ Project ID              │ e8d92d22-2946-4a96-8ee6-b6e6c00e74ff                  │
└─────────────────────────┴───────────────────────────────────────────────────────┘
✔ Scheduling Submission
✔ Submitting your app to Apple App Store

Also done

moved command from eas build:submit to eas submit, leaving alias for the first one.
Added FYI pages: [FYI] Add FYIs for iOS app submission stuff fyi#15

TODO (future PR)

Replace travelingFastlane with JS API after it supports iTunes teams/providers.
~~Find a name for --app-apple-id~~ Renamed to --asc-app-id

Note: I'm repeating myself but this name is really confusing. The --asc-app-id param is corresponding to appAppleId variable, on ASC it's this one:

It's in App Store Connect under General ->App Information

packages/eas-cli/src/commands/build/submit.ts

packages/eas-cli/src/submissions/ios/AppProduce.ts

packages/eas-cli/src/commands/build/submit.ts

brentvatne · 2020-11-21T00:03:18Z

You can also specify ios.bundleIdentifier in app.json file

we should use the term app config instead:

You can also specify ios.bundleIdentifier in your app config file.

we can use terminal-link to link out to the docs.

brentvatne · 2020-11-21T02:06:08Z

will follow up with a more thorough review next week :)

one other thing we may want to do here is move this command out of the build namespace. it's possible that developers will want to use eas submit without using eas build, especially as we add more features to it over time

dsokal

Great job, take a look at my inline comments!

dsokal · 2020-11-23T08:21:47Z

packages/eas-cli/src/commands/build/submit.ts

+    'bundle-identifier': flags.string({
+      description: 'Your iOS Bundle Identifier (default: expo.ios.bundleIdentifier from app.json)',
+    }),


Hmm, I'm not sure if this should be a command param. I'm not saying it's undesirable but rather we don't have a similar param for build commands.

Hmm, my current flow assumed:

Get bundle ID from this param

Then try to gather it from exp config

Finally, prompt user

But according to the comment below (about using getBundleIdentifier()), the flow can be changed to just gather it from param or config (remove prompt).

Providing bundle ID as param / asking for it is useful only in cases when user wants to submit an external binary and/or, if ever possible, to run eas submit from outside project directory (manifest not available).

packages/eas-cli/src/submissions/ios/AppProduce.ts

packages/eas-cli/src/submissions/ios/AppSpecificPasswordSource.ts

packages/eas-cli/src/submissions/ios/IosSubmitCommand.ts

packages/eas-cli/src/submissions/ios/utils/language.ts

dsokal · 2020-11-23T08:38:54Z

I'm in favor of --asc-app-id

wkozyra95 · 2020-11-23T11:40:47Z

@brentvatne

You can also specify ios.bundleIdentifier in your app config file.

we can use terminal-link to link out to the docs.

Proper behavior of terminal link should be that if it's supported it should display text and if it's not display URL, but there are terminals that display text and it's not clickable. termianl-link has isSupported method that returns true in those cases, but links do not work. If we can't properly detect those cases we shouldn't use that lib at all.

barthap · 2020-11-23T11:42:15Z

Proper behavior of terminal link should be that if it's supported it should display text and if it's not display URL, but there are terminals that display text and is not clickable. termianl-link has isSupported method that returns true in those cases, but links do not work. If we can't properly detect those cases we shouldn't use that lib at all.

That's the exact reason why I didn't use terminal-link here

brentvatne · 2020-11-25T06:41:25Z

which terminals are you concerned about? we use terminal-link extensively in expo-cli and intend to continue to use it in our cli tools so we should probably make this a broader discussion if there is some concern, rather than diverging on a per-command basis :) (this is not a blocker for this PR, just something we should discuss at some point to agree on a common strategy for these types of links)

wkozyra95 · 2020-11-25T09:24:26Z

@brentvatne
I didn't test different terminals extensively, but it does not work in the one I'm using terminator and I tested that on one more Linux terminal (I think it was gnome-terminal, but I'm not 100% sure) and it also didn't work there.

packages/eas-cli/src/commands/submit.ts

packages/eas-cli/src/submissions/ios/AppSpecificPasswordSource.ts

packages/eas-cli/src/commands/submit.ts

packages/eas-cli/src/build/ios/bundleIdentifer.ts

barthap force-pushed the @barthap/submissions/app-produce branch from 2a8c2ed to 4884010 Compare November 20, 2020 08:28

barthap changed the title ~~@barthap/submissions/app produce~~ [eas-cli] Add AppStore app creation to submission command Nov 20, 2020

barthap marked this pull request as ready for review November 20, 2020 09:14

barthap requested review from dsokal, wkozyra95 and brentvatne November 20, 2020 09:14

wkozyra95 reviewed Nov 20, 2020

View reviewed changes

packages/eas-cli/src/commands/build/submit.ts Outdated Show resolved Hide resolved

packages/eas-cli/src/submissions/ios/AppProduce.ts Outdated Show resolved Hide resolved

packages/eas-cli/src/commands/build/submit.ts Show resolved Hide resolved

dsokal approved these changes Nov 23, 2020

View reviewed changes

barthap added 8 commits November 23, 2020 12:31

Bump traveling-fastlane to 1.15.2

343a58a

Remove --app-specific-password flag

9974688

Add fastlane utility

bcb7dc6

WIP

2130332

Fastlane-based app store create

e8b7d54

Update flags description

4361ed2

Fix comments

4e6fd77

Password prompt type

8055303

barthap added 2 commits November 23, 2020 12:49

Update help

7393645

Address some feedback

2aca849

barthap force-pushed the @barthap/submissions/app-produce branch from c6ea47d to 2aca849 Compare November 23, 2020 12:12

barthap added 3 commits November 24, 2020 08:18

fix getenv

ed3bd4b

Move to eas submit, bundleId, fyi, --asc-app-id

8c5d035

Merge 'origin/main' into @barthap/submissions/app-produce

9056368

barthap requested a review from wkozyra95 November 25, 2020 08:24

wkozyra95 approved these changes Nov 25, 2020

View reviewed changes

dsokal approved these changes Nov 25, 2020

View reviewed changes

Apply suggestions + improvements

a18f847

barthap merged commit 2ae64e7 into main Nov 25, 2020

barthap deleted the @barthap/submissions/app-produce branch November 25, 2020 10:56

This was referenced Nov 26, 2020

Improve error/warning messages #88

Merged

Terminal-link usage #89

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[eas-cli] Add AppStore app creation to submission command #65

[eas-cli] Add AppStore app creation to submission command #65

barthap commented Nov 13, 2020 •

edited

Loading

brentvatne commented Nov 21, 2020

brentvatne commented Nov 21, 2020

dsokal left a comment

dsokal Nov 23, 2020

barthap Nov 24, 2020

dsokal commented Nov 23, 2020

wkozyra95 commented Nov 23, 2020 •

edited

Loading

barthap commented Nov 23, 2020

brentvatne commented Nov 25, 2020 •

edited

Loading

wkozyra95 commented Nov 25, 2020

[eas-cli] Add AppStore app creation to submission command #65

[eas-cli] Add AppStore app creation to submission command #65

Conversation

barthap commented Nov 13, 2020 • edited Loading

Command flow

Example output

Also done

TODO (future PR)

brentvatne commented Nov 21, 2020

brentvatne commented Nov 21, 2020

dsokal left a comment

Choose a reason for hiding this comment

dsokal Nov 23, 2020

Choose a reason for hiding this comment

barthap Nov 24, 2020

Choose a reason for hiding this comment

dsokal commented Nov 23, 2020

wkozyra95 commented Nov 23, 2020 • edited Loading

barthap commented Nov 23, 2020

brentvatne commented Nov 25, 2020 • edited Loading

wkozyra95 commented Nov 25, 2020

barthap commented Nov 13, 2020 •

edited

Loading

wkozyra95 commented Nov 23, 2020 •

edited

Loading

brentvatne commented Nov 25, 2020 •

edited

Loading