Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] do not set default image #675

Merged
merged 4 commits into from Oct 8, 2021
Merged

Conversation

wkozyra95
Copy link
Contributor

@wkozyra95 wkozyra95 commented Oct 7, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

We always specify the image field in the job object. As a result, when processing the build in the backend, we don't know whether the image was specified explicitly or by default.

How

Don't resolve the image in the CLI.

Test Plan

Tested manually.

@wkozyra95 wkozyra95 requested a review from dsokal October 7, 2021 13:39
Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix type errors.

@dsokal
Copy link
Contributor

dsokal commented Oct 7, 2021

... and add a changelog entry.

@dsokal dsokal force-pushed the @wkozyra95/do-not-set-default-image branch from 39eda53 to f26befb Compare October 8, 2021 10:37
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Size Change: +320 B (0%)

Total Size: 22.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 22.5 MB +320 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #675 (b3fadab) into main (e30f62e) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   49.61%   49.64%   +0.03%     
==========================================
  Files         313      313              
  Lines       10811    10803       -8     
  Branches     2015     2011       -4     
==========================================
- Hits         5363     5362       -1     
+ Misses       5442     5435       -7     
  Partials        6        6              
Impacted Files Coverage Δ
packages/eas-cli/src/build/android/prepareJob.ts 36.37% <ø> (+1.59%) ⬆️
packages/eas-cli/src/build/ios/prepareJob.ts 34.79% <ø> (+4.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30f62e...b3fadab. Read the comment docs.

@dsokal dsokal merged commit 5879ac4 into main Oct 8, 2021
@dsokal dsokal deleted the @wkozyra95/do-not-set-default-image branch October 8, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants