Skip to content

Commit

Permalink
[Android][expo-filesystem] Fix FileSystem.downloadAsync throwing Null…
Browse files Browse the repository at this point in the history
…PointerException

* add null safe check in FileSystem#downloadAsync java implementation

fix #6818

* document fix in changelog
  • Loading branch information
jsamr authored and EvanBacon committed Feb 13, 2020
1 parent 1b92613 commit 09a30e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ This is the log of notable changes to the Expo client that are developer-facing.
- Fixed fullscreen events on iOS for native controls. ([#6504](https://github.com/expo/expo/pull/6504) by [@mczernek](https://github.com/mczernek))
- Fixed `Camera.takePictureAsync()` not saving metadata on iOS. ([#6428](https://github.com/expo/expo/pull/6428) by [@lukmccall](https://github.com/lukmccall))
- Fixed `KeyboardAvoidingView` in standalone Android builds. ([#6506](https://github.com/expo/expo/pull/6506) [@bbarthec](https://github.com/bbarthec))
- Fixed `FileSystem.downloadAsync()` throwing `NullPointerException` in rare failures on Android. ([#6819](https://github.com/expo/expo/pull/6819) by [@jsamr](https://github.com/jsamr/))

## 36.0.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ public void downloadAsync(String url, final String uriStr, final Map<String, Obj
getOkHttpClient().newCall(requestBuilder.build()).enqueue(new Callback() {
@Override
public void onFailure(Call call, IOException e) {
Log.e(TAG, e.getMessage());
Log.e(TAG, String.valueOf(e.getMessage()));
promise.reject(e);
}

Expand Down

0 comments on commit 09a30e3

Please sign in to comment.