-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dev-launcher][iOS] Fix navigating to home from Dev menu (#26045)
# Why Closes ENG-10953 When navigating to home from dev-menu in an app dev-client with new arch enabled on iOS the app will crash due to `"AccessibilityManager is nil" due to the registry is nil` inside `RCTDeviceInfo`. This happens because when we invalidate the old bridge, create a new one, and then manually post an `RCTUserInterfaceStyleDidChangeNotification` notification, it gets received by an old instance of RCTDeviceInfo and then fails to find the module as the bridge is no longer valid. Removing the `_ensureUserInterfaceStyleIsInSyncWithTraitEnv` call from `navigateToLauncher` fixes this racing condition issue and it doesn't seem to create any problems related to UserInterfaceStyle Created this issue on react-native core facebook/react-native#42120 # How - Remove `_ensureUserInterfaceStyleIsInSyncWithTraitEnv` call from `navigateToLauncher` - Add minimum support to dark mode on fabric-tester # Test Plan https://github.com/expo/expo/assets/11707729/54a6b68e-8db8-4296-8c9b-29fa314cafb5 # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
- Loading branch information
1 parent
7666e62
commit 0bcc1ce
Showing
4 changed files
with
34 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters