Skip to content

Commit

Permalink
chore(expo-router): reduce usage of expo-constants (#26834)
Browse files Browse the repository at this point in the history
# Why

- reduce chance of issues like this
expo/router#918
- Using globals directly is the future. A lot less bundling and
resolving.

# Test Plan

Manually ran this in a dev client, web, and expo go for ios.

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
  • Loading branch information
EvanBacon and expo-bot committed Feb 1, 2024
1 parent b362564 commit 12d93da
Show file tree
Hide file tree
Showing 24 changed files with 58 additions and 103 deletions.
1 change: 1 addition & 0 deletions packages/@expo/cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

### 💡 Others

- Change server log tag. ([#26834](https://github.com/expo/expo/pull/26834) by [@EvanBacon](https://github.com/EvanBacon))
- Eagerly perform iOS system checks to speed up iOS simulator launches. ([#26746](https://github.com/expo/expo/pull/26746) by [@EvanBacon](https://github.com/EvanBacon))
- Improve warning for favicon missing during web export. ([#26733](https://github.com/expo/expo/pull/26733) by [@EvanBacon](https://github.com/EvanBacon))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ function getEnvironmentForBuildDetails(bundleDetails?: BundleDetails | null): st
// Expo CLI will pass `customTransformOptions.environment = 'node'` when bundling for the server.
const env = bundleDetails?.customTransformOptions?.environment ?? null;
if (env === 'node') {
return `${chalk.bold(' λ ')} `;
return chalk.bold('λ') + ' ';
}

return '';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`_getBundleStatusMessage should format standard progress for a server invocation 1`] = `" λ ./index.js ▓▓▓▓▓▓▓▓░░░░░░░░ 50.0% ( 50/100)"`;
exports[`_getBundleStatusMessage should format standard progress for a server invocation 1`] = `"λ ./index.js ▓▓▓▓▓▓▓▓░░░░░░░░ 50.0% ( 50/100)"`;
1 change: 1 addition & 0 deletions packages/expo-router/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

### 💡 Others

- Reduce usage of `expo-constants`. ([#26834](https://github.com/expo/expo/pull/26834) by [@EvanBacon](https://github.com/EvanBacon))
- Deprecate `useRootNavigation` in favor of `useNavigationContainerRef`. ([#26529](https://github.com/expo/expo/pull/26529) by [@EvanBacon](https://github.com/EvanBacon))
- Remove duplicate context mocking functions ([#26651](https://github.com/expo/expo/pull/26651) by [@marklawlor](https://github.com/marklawlor))

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/expo-router/build/fork/extractPathFromURL.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-router/build/fork/extractPathFromURL.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/expo-router/build/head/ExpoHeadModule.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-router/build/head/ExpoHeadModule.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion packages/expo-router/build/head/ExpoHeadModule.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 12d93da

Please sign in to comment.