-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dev-menu][dev-launcher] fix jsc support (#27507)
# Why fixes #27357 close ENG-11541 # How since expo 50 with android minSdkVersion 23, native libs are lived inside apk. the current react-native's soloader does not support this flow for `SoLoader.getLibraryPath()`. we use this method in [jsc detection](https://github.com/expo/expo/blob/3d2157c5d9a351cd692fe245a1134a6d9540b0b8/packages/expo-dev-launcher/android/src/react-native-72/debug/expo/modules/devlauncher/rncompatibility/DevLauncherReactNativeHostHandler.kt#L38). the newer soloader 0.11.0 added the support. one risky concern is that react-native currently only has soloader 0.10.5. when bumping the soloader, the dependency is affected to the whole app. but i believe meta internally used the latest soloader already. it's good to try out and see how it goes. # Test Plan update jsEngine=jsc in bare-expo and launch dev-launcher/dev-menu on bare-expo
- Loading branch information
Showing
4 changed files
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters