[expo-av] Fix mem-leak when unmounting Video component (#9379)

* [expo-av] Fix mem-leak when unmounting Video view * [expo-av] Clean-up unused observers * [expo-av] Update changelog
expo · Jul 24, 2020 · 37f133d · 37f133d
1 parent e9aa9df
commit 37f133d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/packages/expo-av/CHANGELOG.md b/packages/expo-av/CHANGELOG.md
@@ -13,6 +13,7 @@
 - Prevent debugger break when removing observations. ([#9334](https://github.com/expo/expo/pull/9334) by [@IjzerenHein](https://github.com/IjzerenHein))
 - Fix iOS stability issue due to player-item observers not cleaned up. ([#9350](https://github.com/expo/expo/pull/9350) by [@IjzerenHein](https://github.com/IjzerenHein))
 - Fix duplicate full-screen will-dismiss event on iOS. ([#9366](https://github.com/expo/expo/pull/9366) by [@IjzerenHein](https://github.com/IjzerenHein))
+- Fix mem-leak when unmounting Video component. ([#9379](https://github.com/expo/expo/pull/9379) by [@IjzerenHein](https://github.com/IjzerenHein))
 - De-activate audio-session after unloading sound. ([#9365](https://github.com/expo/expo/pull/9365) by [@IjzerenHein](https://github.com/IjzerenHein))
 - Fix resume audio when in background. ([#9363](https://github.com/expo/expo/pull/9363) by [@IjzerenHein](https://github.com/IjzerenHein))
 - Fix instability issues when changing source and useNativeControls. ([#9381](https://github.com/expo/expo/pull/9381) by [@IjzerenHein](https://github.com/IjzerenHein))

diff --git a/packages/expo-av/ios/EXAV/EXAV.m b/packages/expo-av/ios/EXAV/EXAV.m
@@ -46,7 +46,7 @@ @interface EXAV ()
 @property (nonatomic, assign) int soundDictionaryKeyCount;
 @property (nonatomic, strong) NSMutableDictionary <NSNumber *, EXAVPlayerData *> *soundDictionary;
 @property (nonatomic, assign) BOOL isBeingObserved;
-@property (nonatomic, strong) NSMutableSet <NSObject<EXAVObject> *> *videoSet;
+@property (nonatomic, strong) NSHashTable <NSObject<EXAVObject> *> *videoSet;
 
 @property (nonatomic, strong) NSString *audioRecorderFilename;
 @property (nonatomic, strong) NSDictionary *audioRecorderSettings;
@@ -79,7 +79,7 @@ - (instancetype)init
     _soundDictionaryKeyCount = 0;
     _soundDictionary = [NSMutableDictionary new];
     _isBeingObserved = NO;
-    _videoSet = [NSMutableSet new];
+    _videoSet = [NSHashTable weakObjectsHashTable];
 
     _audioRecorderFilename = nil;
     _audioRecorderSettings = nil;

diff --git a/packages/expo-av/ios/EXAV/Video/EXVideoView.m b/packages/expo-av/ios/EXAV/Video/EXVideoView.m
@@ -634,7 +634,6 @@ - (void)removeFromSuperview
 {
   [self _removeData];
   [self _removePlayer];
-  [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super removeFromSuperview];
 }
 
@@ -743,7 +742,6 @@ - (void)handleMediaServicesReset:(void (^)(void))finishCallback
 - (void)dealloc
 {
   [_exAV unregisterVideoForAudioLifecycle:self];
-  [[NSNotificationCenter defaultCenter] removeObserver:self];
   [_data pauseImmediately];
   [_exAV demoteAudioSessionIfPossible];
 }