Skip to content

Commit

Permalink
[AV] Return empty list as cookies list instead of null (#6320)
Browse files Browse the repository at this point in the history
# Why

Fix [issue](#3258) on some android devices caused by null cookies list.

# Test Plan

https://snack.expo.io/rJHDOvS_r this snack shows error, when running on Android 7 emulator.
  • Loading branch information
mczernek authored and tsapeta committed Nov 19, 2019
1 parent efefd1d commit 71364e0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -36,6 +36,7 @@ This is the log of notable changes to the Expo client that are developer-facing.

### 🐛 Bug fixes

- Fixed `MediaPlayer` not working on some Android devices ([#6320](https://github.com/expo/expo/pull/6320) by [@mczernek](https://github.com/mczernek))
- Fixed `Audio.setAudioModeAsync` to auto-fill with previously set values (falls back to default values) if not all fields are provided by [@cruzach](https://github.com/cruzach) ([#5593](https://github.com/expo/expo/pull/5593))
- Fixed crash when `BarCodeScanner` was mounted more than 128 times. ([#5719](https://github.com/expo/expo/pull/5719) by [@geovannimp](https://github.com/geovannimp))
- Fixed URI parsing in `expo-video-thumbnails`. ([#5711](https://github.com/expo/expo/pull/5711) by [@lukmccall](https://github.com/lukmccall))
Expand Down
Expand Up @@ -420,7 +420,7 @@ private List<HttpCookie> getHttpCookiesList() {
}
return httpCookies;
} else {
return null;
return Collections.emptyList();
}
} catch (IOException e) {
// do nothing, we'll return an empty list
Expand Down

0 comments on commit 71364e0

Please sign in to comment.