chore(expo-router): reduce usage of expo-constants (#26834)

- reduce chance of issues like this expo/router#918 - Using globals directly is the future. A lot less bundling and resolving. Manually ran this in a dev client, web, and expo go for ios. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo · Feb 1, 2024 · dd09948 · dd09948
1 parent dc6416e
commit dd09948
Show file tree

Hide file tree

Showing 23 changed files with 58 additions and 103 deletions.
diff --git a/packages/@expo/cli/src/start/server/metro/MetroTerminalReporter.ts b/packages/@expo/cli/src/start/server/metro/MetroTerminalReporter.ts
@@ -238,7 +238,7 @@ function getEnvironmentForBuildDetails(bundleDetails?: BundleDetails | null): st
   // Expo CLI will pass `customTransformOptions.environment = 'node'` when bundling for the server.
   const env = bundleDetails?.customTransformOptions?.environment ?? null;
   if (env === 'node') {
-    return `${chalk.bold(' λ ')} `;
+    return chalk.bold('λ') + ' ';
   }
 
   return '';

diff --git a/...xpo/cli/src/start/server/metro/__tests__/__snapshots__/MetroTerminalReporter-test.ts.snap b/...xpo/cli/src/start/server/metro/__tests__/__snapshots__/MetroTerminalReporter-test.ts.snap
@@ -1,3 +1,3 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`_getBundleStatusMessage should format standard progress for a server invocation 1`] = `" λ  ./index.js ▓▓▓▓▓▓▓▓░░░░░░░░ 50.0% ( 50/100)"`;
+exports[`_getBundleStatusMessage should format standard progress for a server invocation 1`] = `"λ ./index.js ▓▓▓▓▓▓▓▓░░░░░░░░ 50.0% ( 50/100)"`;
diff --git a/packages/expo-router/CHANGELOG.md b/packages/expo-router/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 ### 💡 Others
 
+- Reduce usage of `expo-constants`. ([#26834](https://github.com/expo/expo/pull/26834) by [@EvanBacon](https://github.com/EvanBacon))
+
 ## 3.4.6 — 2024-01-26
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-router/build/fork/extractPathFromURL.d.ts.map b/packages/expo-router/build/fork/extractPathFromURL.d.ts.map
diff --git a/packages/expo-router/build/fork/extractPathFromURL.js b/packages/expo-router/build/fork/extractPathFromURL.js
diff --git a/packages/expo-router/build/fork/extractPathFromURL.js.map b/packages/expo-router/build/fork/extractPathFromURL.js.map
diff --git a/packages/expo-router/build/head/ExpoHeadModule.d.ts b/packages/expo-router/build/head/ExpoHeadModule.d.ts
diff --git a/packages/expo-router/build/head/ExpoHeadModule.d.ts.map b/packages/expo-router/build/head/ExpoHeadModule.d.ts.map
diff --git a/packages/expo-router/build/head/ExpoHeadModule.js b/packages/expo-router/build/head/ExpoHeadModule.js