Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers with underscore separators cause error on Android #12042

Closed
xavierstampslafont opened this issue Feb 25, 2021 · 2 comments
Closed

Numbers with underscore separators cause error on Android #12042

xavierstampslafont opened this issue Feb 25, 2021 · 2 comments
Labels
needs validation Issue needs to be validated

Comments

@xavierstampslafont
Copy link

Summary

If a number has underscore separators in it, e.g. 1_000, it will cause this error on Android (both on emulator and on device): No identifiers allowed directly after numeric literal

It works fine on iOS. Ideally it should work for Android too!

Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!

managed

What platform(s) does this occur on?

Android

SDK Version (managed workflow only)

No response

Environment

Expo CLI 4.1.3 environment info:
System:
OS: macOS 11.2
Shell: 5.8 - /bin/zsh
Binaries:
Node: 15.5.0 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 7.5.4 - /usr/local/bin/npm
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
IDEs:
Android Studio: 4.1 AI-201.8743.12.41.7042882
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
npmPackages:
expo: ~40.0.0 => 40.0.1
react: 16.13.1 => 16.13.1
react-dom: 16.13.1 => 16.13.1
react-native: https://github.com/expo/react-native/archive/sdk-40.0.1.tar.gz => 0.63.2
react-native-web: ~0.13.12 => 0.13.18
npmGlobalPackages:
expo-cli: 4.1.3
Expo Workflow: managed

Reproducible demo or steps to reproduce from a blank project

https://snack.expo.io/ns4xL2JLk

@xavierstampslafont xavierstampslafont added the needs validation Issue needs to be validated label Feb 25, 2021
@AdamJNavarro
Copy link
Contributor

Hey @xavierstampslafont, this falls out of the scope of Expo but rather deals with JavaScript's implementation itself.

@xavierstampslafont
Copy link
Author

Is it because of different JS engines being used for Android vs iOS?

If you're aware of where else I can raise this issue, I'd appreciate any help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs validation Issue needs to be validated
Projects
None yet
Development

No branches or pull requests

2 participants